From 5badc52698df2af3a560c2c4c13e4ccfc6657149 Mon Sep 17 00:00:00 2001
From: dudeitsjesse <jesse.elliott.martin@gmail.com>
Date: Fri, 6 Jul 2018 14:32:11 -0700
Subject: [PATCH] refactor updateQuality and add support for conjured items

---
 js/src/gilded_rose.js | 89 +++++++++++++++++++++----------------------
 1 file changed, 44 insertions(+), 45 deletions(-)

diff --git a/js/src/gilded_rose.js b/js/src/gilded_rose.js
index 5358125e..ce27e06b 100644
--- a/js/src/gilded_rose.js
+++ b/js/src/gilded_rose.js
@@ -1,5 +1,5 @@
 class Item {
-  constructor(name, sellIn, quality){
+  constructor(name, sellIn, quality) {
     this.name = name;
     this.sellIn = sellIn;
     this.quality = quality;
@@ -7,56 +7,55 @@ class Item {
 }
 
 class Shop {
-  constructor(items=[]){
+  constructor(items = []) {
     this.items = items;
   }
-  updateQuality() {
-    for (var i = 0; i < this.items.length; i++) {
-      if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
-        if (this.items[i].quality > 0) {
-          if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
-            this.items[i].quality = this.items[i].quality - 1;
-          }
-        }
+  increaseQuality(item) {
+    if (item.quality < 50) {
+      item.quality++;
+    }
+    return item;
+  }
+  decreaseQuality(item) {
+    if (item.quality > 0) {
+      if (item.sellIn < 0 || item.name === 'Conjured Mana Cake') {
+        item.quality = item.quality - 2 > 0 ? item.quality - 2 : 0;
       } else {
-        if (this.items[i].quality < 50) {
-          this.items[i].quality = this.items[i].quality + 1;
-          if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
-            if (this.items[i].sellIn < 11) {
-              if (this.items[i].quality < 50) {
-                this.items[i].quality = this.items[i].quality + 1;
-              }
-            }
-            if (this.items[i].sellIn < 6) {
-              if (this.items[i].quality < 50) {
-                this.items[i].quality = this.items[i].quality + 1;
-              }
-            }
-          }
-        }
-      }
-      if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
-        this.items[i].sellIn = this.items[i].sellIn - 1;
-      }
-      if (this.items[i].sellIn < 0) {
-        if (this.items[i].name != 'Aged Brie') {
-          if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
-            if (this.items[i].quality > 0) {
-              if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
-                this.items[i].quality = this.items[i].quality - 1;
-              }
-            }
-          } else {
-            this.items[i].quality = this.items[i].quality - this.items[i].quality;
-          }
-        } else {
-          if (this.items[i].quality < 50) {
-            this.items[i].quality = this.items[i].quality + 1;
-          }
-        }
+        item.quality--;
       }
     }
+    return item;
+  }
+  updateQuality() {
+    this.items.map(item => {
+      switch (item.name) {
+        case 'Aged Brie':
+          this.increaseQuality(item);
+          item.sellIn--;
+          break;
+        case 'Backstage passes to a TAFKAL80ETC concert':
+          if (item.sellIn > 0) {
+            this.increaseQuality(item);
+            if (item.sellIn < 11) {
+              this.increaseQuality(item);
+            }
+            if (item.sellIn < 6) {
+              this.increaseQuality(item);
+            }
+          } else {
+            item.quality = 0;
+          }
+          item.sellIn--;
+          break;
+        case 'Sulfuras, Hand of Ragnaros':
+          item.sellIn--;
+          break;
 
+        default:
+          this.decreaseQuality(item);
+          item.sellIn--;
+      }
+    });
     return this.items;
   }
 }