OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

拆除多餘的 if else for sellin < 0

Browse Source
This commit is contained in:
jiajun.chou 2020-08-13 21:55:35 +08:00
parent ef7eb587ec
commit 5db134a70f
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -10,9 +10,13 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (Item item : items) { for (Item item : items) {
if (item.name.equals("Aged Brie")) { if (item.name.equals("Aged Brie")) {
plusOneQuilaty_if_less_than_fifth(item); plusOneQuilaty_if_less_than_fifth(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { } else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality < 50) { if (item.quality < 50) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
@ -24,7 +28,9 @@ class GildedRose {
plusOneQuilaty_if_less_than_fifth(item); plusOneQuilaty_if_less_than_fifth(item);
} }
} }
} else { } else {
caculateQuilaty_without_Sulfuras(item); caculateQuilaty_without_Sulfuras(item);
} }
@ -37,12 +43,10 @@ class GildedRose {
if (item.sellIn < 0) { if (item.sellIn < 0) {
if (item.name.equals("Aged Brie")) { if (item.name.equals("Aged Brie")) {
plusOneQuilaty_if_less_than_fifth(item); plusOneQuilaty_if_less_than_fifth(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
item.quality = item.quality - item.quality;
} else { } else {
if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { caculateQuilaty_without_Sulfuras(item);
item.quality = item.quality - item.quality;
} else {
caculateQuilaty_without_Sulfuras(item);
}
} }
} }
} }