OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-19 00:11:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(name): added constant names

Browse Source
This commit is contained in:
Miguel Caro 2022-01-31 20:39:30 -05:00
parent e0d2e5c555
commit 6468212b02
2 changed files with 44 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.prettierrc Normal file
View File

@ -0,0 +1,3 @@
{
"singleQuote": true
}

64
app/gilded-rose.ts
View File

@ -10,6 +10,18 @@ export class Item {
} }
} }
enum ItemType {
AgedBrie = 'Aged Brie',
BackstagePasses = 'Backstage passes to a TAFKAL80ETC concert',
Sulfuras = 'Sulfuras, Hand of Ragnaros',
}
const TEN_DAYS_FOR_THE_CONCERT = 11;
const FIVE_DAYS_FOR_THE_CONCERT = 6;
const ZERO_DAYS_FOR_SALE = 0;
const MAX_QUALITY = 50;
const MIN_QUALITY = 0;
export class GildedRose { export class GildedRose {
items: Array<Item>; items: Array<Item>;
@ -19,46 +31,52 @@ export class GildedRose {
updateQuality() { updateQuality() {
for (let i = 0; i < this.items.length; i++) { for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (
if (this.items[i].quality > 0) { this.items[i].name != ItemType.AgedBrie &&
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { this.items[i].name != ItemType.BackstagePasses
this.items[i].quality = this.items[i].quality - 1 ) {
if (this.items[i].quality > MIN_QUALITY) {
if (this.items[i].name != ItemType.Sulfuras) {
this.items[i].quality = this.items[i].quality - 1;
} }
} }
} else { } else {
if (this.items[i].quality < 50) { if (this.items[i].quality < MAX_QUALITY) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality = this.items[i].quality + 1;
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') { if (this.items[i].name == ItemType.BackstagePasses) {
if (this.items[i].sellIn < 11) { if (this.items[i].sellIn < TEN_DAYS_FOR_THE_CONCERT) {
if (this.items[i].quality < 50) { if (this.items[i].quality < MAX_QUALITY) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality = this.items[i].quality + 1;
} }
} }
if (this.items[i].sellIn < 6) { if (this.items[i].sellIn < FIVE_DAYS_FOR_THE_CONCERT) {
if (this.items[i].quality < 50) { if (this.items[i].quality < MAX_QUALITY) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality = this.items[i].quality + 1;
} }
} }
} }
} }
} }
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
if (this.items[i].name != ItemType.Sulfuras) {
this.items[i].sellIn = this.items[i].sellIn - 1; this.items[i].sellIn = this.items[i].sellIn - 1;
} }
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') { if (this.items[i].sellIn < ZERO_DAYS_FOR_SALE) {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (this.items[i].name != ItemType.AgedBrie) {
if (this.items[i].quality > 0) { if (this.items[i].name != ItemType.BackstagePasses) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (this.items[i].quality > MIN_QUALITY) {
this.items[i].quality = this.items[i].quality - 1 if (this.items[i].name != ItemType.Sulfuras) {
this.items[i].quality = this.items[i].quality - 1;
} }
} }
} else { } else {
this.items[i].quality = this.items[i].quality - this.items[i].quality this.items[i].quality =
this.items[i].quality - this.items[i].quality;
} }
} else { } else {
if (this.items[i].quality < 50) { if (this.items[i].quality < MAX_QUALITY) {
this.items[i].quality = this.items[i].quality + 1 this.items[i].quality = this.items[i].quality + 1;
} }
} }
} }