From 67769ddd5721909ce46b3505c463ba16e79b4118 Mon Sep 17 00:00:00 2001 From: Santiago Garcia Date: Tue, 29 Sep 2020 17:55:12 -0500 Subject: [PATCH] fix code smells --- Java/src/main/java/com/gildedrose/GildedRose.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 34ec6293..4bd1fb49 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -16,14 +16,13 @@ class GildedRose { public void updateQuality() { for (int i = 0; i < items.length; i++) { reduceSellInItem(i); - if (isEspecialItem(items[i])) { valueItems(i); } else { devalueItems(i); } if (items[i].sellIn < 0) { - qualityWhenDaysAreOver(i); + alterQualityWhenDaysAreOver(i); } } } @@ -46,7 +45,7 @@ class GildedRose { } } - private void qualityWhenDaysAreOver(int i) { + private void alterQualityWhenDaysAreOver(int i) { if (items[i].name.equals(AGED_ITEM) && canIncreaseQuality(items[i].quality)) { increaseQuality(i); } else if (items[i].name.equals(BACKSTAGE_ITEM)) {