OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: fix the negative number logic

Browse Source
This commit is contained in:
sirlolcat 2022-06-04 23:43:09 +04:30
parent 58f35a4fd5
commit 6818eda220
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
react-typescript/src/model/reducer/calculateQuality.ts
View File

@ -28,14 +28,10 @@ function calculateQuality(state: TItem): number {
} }
} }
if(state.isConjured) { if(state.isConjured || state.sellIn < 0) {
degradeRate = 2; degradeRate = 2;
} }
if(state.sellIn <= 0) {
return calculatedQuality;
}
calculatedQuality = calculatedQuality - (qualityIdentifier * degradeRate); calculatedQuality = calculatedQuality - (qualityIdentifier * degradeRate);
if(calculatedQuality > 50) { if(calculatedQuality > 50) {

8
react-typescript/src/model/reducer/calculateSellIn.ts
View File

@ -5,13 +5,7 @@ function updateSellIn (state: any): number {
return calculatedSellIn; return calculatedSellIn;
} }
calculatedSellIn = calculatedSellIn - 1; return calculatedSellIn - 1;
if(calculatedSellIn < 0) {
return 0;
}
return calculatedSellIn;
} }
export default updateSellIn; export default updateSellIn;