OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

naming and empty lines fixes

Browse Source
This commit is contained in:
saulius12 2019-06-13 22:56:07 +03:00
parent fa45a7f8d5
commit 6a07035df0
6 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
php7/src/BackstagePasses.php
View File

@ -14,18 +14,23 @@ class BackstagePasses extends GildedRose
public function updateQuality(){
$this->item->quality += 1;
if ($this->item->sell_in <= 10) {
$this->item->quality += 1;
}
if ($this->item->sell_in <= 5) {
$this->item->quality += 1;
}
if ($this->item->quality > 50) {
$this->item->quality = 50;
}
if ($this->item->sell_in <= 0) {
$this->item->quality = 0;
}
$this->item->sell_in -= 1;
}
}

1
php7/src/Conjured.php
View File

@ -11,6 +11,7 @@ class Conjured
public function __construct($item) {
$this->item = $item;
}
public function updateQuality(){
$this->item->quality -= 2;

1
php7/src/DefaultItem.php
View File

@ -11,6 +11,7 @@ class DefaultItem extends GildedRose
public function __construct($item) {
$this->item = $item;
}
public function updateQuality(){
$this->item->quality -= 1;

1
php7/src/GildedRose.php
View File

@ -40,6 +40,7 @@ class GildedRose
$sulfaras = new Sulfaras($item);
$sulfaras->updateQuality();
break;
default:
$defoultItem = new DefaultItem($item);
$defoultItem->updateQuality();

1
php7/src/Sulfaras.php
View File

@ -12,6 +12,7 @@ class Sulfaras extends GildedRose
public function __construct($item) {
$this->item = $item;
}
public function updateQuality(){
$this->item->quality = 80;
}

20
php7/test/GildedRoseTest.php
View File

@ -32,7 +32,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 0);
}
public function test_backstage_then_quality_maximum_sell_in_lower_then_zero()
public function test_backstage_then_quality_maximum_sell_in_lower_than_zero()
{
$items = [new Item("Backstage passes to a TAFKAL80ETC concert", -5, 50)];
$gildedRose = new GildedRose($items);
@ -59,7 +59,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 6);
}
public function test_backstage_then_quality_maximum_sell_in_greater_then_ten()
public function test_backstage_then_quality_maximum_sell_in_greater_than_ten()
{
$items = [new Item("Backstage passes to a TAFKAL80ETC concert", 11, 50)];
$gildedRose = new GildedRose($items);
@ -68,7 +68,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 10);
}
public function test_backstage_then_sell_in_greater_then_ten()
public function test_backstage_then_sell_in_greater_than_ten()
{
$items = [new Item("Backstage passes to a TAFKAL80ETC concert", 11, 1)];
$gildedRose = new GildedRose($items);
@ -122,7 +122,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 0);
}
public function test_sulfuras_then_sell_in_lower_then_zero()
public function test_sulfuras_then_sell_in_lower_than_zero()
{
$items = [new Item("Sulfuras, Hand of Ragnaros", -1, 10)];
$gildedRose = new GildedRose($items);
@ -131,7 +131,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, -1);
}
public function test_aged_brie_then_sell_in_greater_then_zero()
public function test_aged_brie_then_sell_in_greater_than_zero()
{
$items = [new Item("Aged Brie", 1, 1)];
$gildedRose = new GildedRose($items);
@ -140,7 +140,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 0);
}
public function test_aged_brie_then_sell_in_lower_then_zero()
public function test_aged_brie_then_sell_in_lower_than_zero()
{
$items = [new Item("Aged Brie", -1, 1)];
$gildedRose = new GildedRose($items);
@ -167,7 +167,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 0);
}
public function test_aged_brie_then_quality_maximum_and_sell_in_lower_then_zero()
public function test_aged_brie_then_quality_maximum_and_sell_in_lower_than_zero()
{
$items = [new Item("Aged Brie", -1, 50)];
$gildedRose = new GildedRose($items);
@ -176,7 +176,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, -2);
}
public function test_aged_brie_then_quality_maximum_and_sell_in_greater_then_zero()
public function test_aged_brie_then_quality_maximum_and_sell_in_greater_than_zero()
{
$items = [new Item("Aged Brie", 1, 50)];
$gildedRose = new GildedRose($items);
@ -194,7 +194,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 9);
}
public function test_conjured_then_sell_in_greater_then_zero()
public function test_conjured_then_sell_in_greater_than_zero()
{
$items = [new Item("Conjured Mana Cake", 1, 5)];
$gildedRose = new GildedRose($items);
@ -203,7 +203,7 @@ class GildedRoseTest extends \PHPUnit\Framework\TestCase
$this->assertEquals($items[0]->sell_in, 0);
}
public function test_conjured_then_sell_in_lower_then_zero()
public function test_conjured_then_sell_in_lower_than_zero()
{
$items = [new Item("Conjured Mana Cake", -1, 5)];
$gildedRose = new GildedRose($items);