OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract method incovation.

Browse Source
This commit is contained in:
Yudai Tanaka 2021-05-07 07:33:18 +09:00
parent b4527830fa
commit 6b60a85ce9
1 changed files with 47 additions and 83 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

130
ruby/gilded_rose_spec.rb
View File

@ -2,13 +2,17 @@ require File.join(File.dirname(__FILE__), "gilded_rose")
describe GildedRose do
describe "#update_quality" do
def updated_items(items)
GildedRose.new(items).update_quality
items
end
it "updates sell_in and quality of multiple items" do
items = [
items = updated_items([
Item.new("Dark Blade", 2, 3),
Item.new("Aged Brie", 2, 3),
Item.new("Backstage passes to a TAFKAL80ETC concert", 2, 3)
]
GildedRose.new(items).update_quality
])
expect(items[0].sell_in).to eq 1
expect(items[0].quality).to eq 2
expect(items[1].sell_in).to eq 1
@ -18,59 +22,48 @@ describe GildedRose do
end
it "does not change the name" do
items = [Item.new("foo", 0, 0)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("foo", 0, 0)])
expect(items[0].name).to eq "foo"
end
it "decreases sell_in by 1" do
items = [Item.new("Dark Blade", 10, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Blade", 10, 5)])
expect(items[0].sell_in).to eq 9
items = [Item.new("Dark Blade", 0, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Blade", 0, 5)])
expect(items[0].sell_in).to eq(-1)
end
it "decreases quality by 1" do
items = [Item.new("Dark Sword", 10, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 10, 5)])
expect(items[0].quality).to eq 4
items = [Item.new("Dark Sword", 1, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 1, 5)])
expect(items[0].quality).to eq 4
end
it "decreases quality down to 0" do
items = [Item.new("Dark Sword", 10, 0)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 10, 0)])
expect(items[0].quality).to eq(0)
end
context "sell_in less than 1" do
it "decreases quality by 2" do
items = [Item.new("Dark Sword", 0, 10)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 0, 10)])
expect(items[0].quality).to eq(8)
items = [Item.new("Dark Sword", -1, 10)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", -1, 10)])
expect(items[0].quality).to eq(8)
end
it "decreases quality down to 0" do
items = [Item.new("Dark Sword", 0, 0)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 0, 0)])
expect(items[0].quality).to eq(0)
items = [Item.new("Dark Sword", 0, 1)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 0, 1)])
expect(items[0].quality).to eq(0)
items = [Item.new("Dark Sword", 0, 2)]
GildedRose.new(items).update_quality
items = updated_items([Item.new("Dark Sword", 0, 2)])
expect(items[0].quality).to eq(0)
end
end
@ -78,39 +71,32 @@ describe GildedRose do
context "when process Aged Brie" do
let(:item_name) { "Aged Brie" }
it "increases quality by 1" do
items = [Item.new(item_name, 10, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 10, 5)])
expect(items[0].quality).to eq 6
items = [Item.new(item_name, 1, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 1, 5)])
expect(items[0].quality).to eq 6
end
it "updates quality up to 50" do
items = [Item.new(item_name, 5, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 50)])
expect(items[0].quality).to eq 50
end
context "when sell_in is less than 1" do
it "increases quality by 2" do
items = [Item.new(item_name, 0, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 5)])
expect(items[0].quality).to eq 7
items = [Item.new(item_name, 0, 48)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 48)])
expect(items[0].quality).to eq 50
end
it "updates quality up to 50" do
items = [Item.new(item_name, 0, 49)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 49)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 0, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 50)])
expect(items[0].quality).to eq 50
end
end
@ -121,90 +107,73 @@ describe GildedRose do
context "when sell_in is greater than to 10" do
it "increases quality by 1" do
items = [Item.new(item_name, 11, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 11, 5)])
expect(items[0].quality).to eq 6
end
it "increases quality up to 50" do
items = [Item.new(item_name, 11, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 11, 50)])
expect(items[0].quality).to eq 50
end
end
context "when sell_in is greater than 5 and less than or equal to 10" do
it "increases quality by 2" do
items = [Item.new(item_name, 10, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 10, 5)])
expect(items[0].quality).to eq 7
items = [Item.new(item_name, 6, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 6, 5)])
expect(items[0].quality).to eq 7
end
it "increases quality up to 50" do
items = [Item.new(item_name, 10, 48)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 10, 48)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 10, 49)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 10, 49)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 10, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 10, 50)])
expect(items[0].quality).to eq 50
end
end
context "when sell_in is less than or equal to 5" do
it "increases quality by 3" do
items = [Item.new(item_name, 5, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 5)])
expect(items[0].quality).to eq 8
items = [Item.new(item_name, 5, 0)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 0)])
expect(items[0].quality).to eq 3
items = [Item.new(item_name, 1, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 1, 5)])
expect(items[0].quality).to eq 8
end
it "increases quality up to 50" do
items = [Item.new(item_name, 5, 47)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 47)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 5, 48)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 48)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 5, 49)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 49)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 5, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 5, 50)])
expect(items[0].quality).to eq 50
end
end
context "when sell_in is less than or equlal to 0" do
it "sets quality to 0" do
items = [Item.new(item_name, 0, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 5)])
expect(items[0].quality).to eq 0
items = [Item.new(item_name, -1, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, -1, 5)])
expect(items[0].quality).to eq 0
items = [Item.new(item_name, 0, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 50)])
expect(items[0].quality).to eq 0
end
end
@ -214,26 +183,21 @@ describe GildedRose do
let(:item_name) { "Sulfuras, Hand of Ragnaros" }
it "does not change quality" do
items = [Item.new(item_name, 1, 50)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 1, 50)])
expect(items[0].quality).to eq 50
items = [Item.new(item_name, 0, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 5)])
expect(items[0].quality).to eq 5
end
it "does not change sell_in" do
items = [Item.new(item_name, 1, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 1, 5)])
expect(items[0].sell_in).to eq 1
items = [Item.new(item_name, 0, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, 0, 5)])
expect(items[0].sell_in).to eq 0
items = [Item.new(item_name, -1, 5)]
GildedRose.new(items).update_quality
items = updated_items([Item.new(item_name, -1, 5)])
expect(items[0].sell_in).to eq(-1)
end
end