OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

合併邏輯，將相同品項的判斷寫在一起

Browse Source
This commit is contained in:
jiajun.chou 2020-08-13 22:07:41 +08:00
parent b713be03e6
commit 7115cd5456
1 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -10,11 +10,19 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (Item item : items) { for (Item item : items) {
if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
if (item.name.equals("Aged Brie")) { return;
} else if (item.name.equals("Aged Brie")) {
plusOneQuilaty_if_less_than_fifth(item); plusOneQuilaty_if_less_than_fifth(item);
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
if (item.sellIn < 0) {
plusOneQuilaty_if_less_than_fifth(item);
}
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { } else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality < 50) { if (item.quality < 50) {
@ -28,22 +36,17 @@ class GildedRose {
plusOneQuilaty_if_less_than_fifth(item); plusOneQuilaty_if_less_than_fifth(item);
} }
} }
item.sellIn = item.sellIn - 1;
} else if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.sellIn = item.sellIn - 1;
if (item.sellIn < 0) {
item.quality = item.quality - item.quality;
}
} else { } else {
caculateQuilaty_without_Sulfuras(item); caculateQuilaty_without_Sulfuras(item);
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} if (item.sellIn < 0) {
if (item.sellIn < 0) {
if (item.name.equals("Aged Brie")) {
plusOneQuilaty_if_less_than_fifth(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
item.quality = item.quality - item.quality;
} else {
caculateQuilaty_without_Sulfuras(item); caculateQuilaty_without_Sulfuras(item);
} }
} }
@ -59,11 +62,7 @@ class GildedRose {
private void caculateQuilaty_without_Sulfuras(Item item) { private void caculateQuilaty_without_Sulfuras(Item item) {
if (item.quality > 0) { if (item.quality > 0) {
if (item.name.equals("Sulfuras, Hand of Ragnaros")) { item.quality = item.quality - 1;
} else {
item.quality = item.quality - 1;
}
} }
} }
} }