OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix code smells

Browse Source
This commit is contained in:
Santiago Garcia 2020-09-29 17:52:44 -05:00
parent 724ab70dd6
commit 727d4b66c4
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,8 +1,12 @@
package com.gildedrose; package com.gildedrose;
class GildedRose { class GildedRose {
Item[] items; private static final int MAX_DEFAULT_QUALITY = 50;
private final int MAX_DEFAULT_QUALITY = 50; private static final String BACKSTAGE_ITEM = "Backstage passes to a TAFKAL80ETC concert";
private static final String CONJURED_ITEM = "Conjured Mana Cake";
private static final String AGED_ITEM = "Aged Brie";
private static final String SULFURAS_ITEM = "Sulfuras, Hand of Ragnaros";
final Item[] items;
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
@ -26,7 +30,7 @@ class GildedRose {
private void valueItems(int i) { private void valueItems(int i) {
if (canIncreaseQuality(items[i].quality)) { if (canIncreaseQuality(items[i].quality)) {
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals(BACKSTAGE_ITEM)) {
increaseValueBackstage(i); increaseValueBackstage(i);
} else { } else {
increaseQuality(i); increaseQuality(i);
@ -35,7 +39,7 @@ class GildedRose {
} }
private void devalueItems(int i) { private void devalueItems(int i) {
if (items[i].name.equals("Conjured Mana Cake")) { if (items[i].name.equals(CONJURED_ITEM)) {
reduceQuality(i, 2); reduceQuality(i, 2);
} else { } else {
reduceQuality(i, 1); reduceQuality(i, 1);
@ -43,19 +47,19 @@ class GildedRose {
} }
private void qualityWhenDaysAreOver(int i) { private void qualityWhenDaysAreOver(int i) {
if (items[i].name.equals("Aged Brie") && canIncreaseQuality(items[i].quality)) { if (items[i].name.equals(AGED_ITEM) && canIncreaseQuality(items[i].quality)) {
increaseQuality(i); increaseQuality(i);
} else if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { } else if (items[i].name.equals(BACKSTAGE_ITEM)) {
items[i].quality = 0; items[i].quality = 0;
} else { } else {
if (items[i].quality > 0 && !items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (items[i].quality > 0 && !items[i].name.equals(SULFURAS_ITEM)) {
reduceQuality(i, 1); reduceQuality(i, 1);
} }
} }
} }
private void reduceSellInItem(int i) { private void reduceSellInItem(int i) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals(SULFURAS_ITEM)) {
items[i].sellIn = items[i].sellIn - 1; items[i].sellIn = items[i].sellIn - 1;
} }
} }
@ -79,8 +83,8 @@ class GildedRose {
} }
private boolean isEspecialItem(Item item) { private boolean isEspecialItem(Item item) {
return item.name.equals("Aged Brie") return item.name.equals(AGED_ITEM)
|| item.name.equals("Backstage passes to a TAFKAL80ETC concert") || item.name.equals("Sulfuras, Hand of Ragnaros"); || item.name.equals(BACKSTAGE_ITEM) || item.name.equals(SULFURAS_ITEM);
} }
private void reduceQuality(int i, int value) { private void reduceQuality(int i, int value) {