From 733a05da1286b001b4dbc2799d4e2ffd085e9c1c Mon Sep 17 00:00:00 2001 From: brianblessou Date: Sun, 12 May 2019 14:46:25 +0200 Subject: [PATCH] create two functions one for decrease and the other to increase quality --- .../main/java/com/gildedrose/GildedRose.java | 46 +++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 7a0c27c0..e5a12d05 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -7,6 +7,18 @@ class GildedRose { this.items = items; } + private void increaseQuality(Item item) { + if (item.quality < 50) { + item.quality += 1; + } + } + + private void decreaseQuality(Item item) { + if (item.quality > 0) { + item.quality -= 1; + } + } + public void updateQuality() { for (Item item : items) { if (item.name.equals("Sulfuras, Hand of Ragnaros")) { @@ -15,27 +27,19 @@ class GildedRose { if (!item.name.equals("Aged Brie") && !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.quality > 0) { - item.quality -= 1; - } + decreaseQuality(item); } else { - if (item.quality < 50) { - item.quality += 1; + increaseQuality(item); + if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (item.sellIn < 11) { + increaseQuality(item); + } - if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.sellIn < 11) { - if (item.quality < 50) { - item.quality += 1; - } - } - - if (item.sellIn < 6) { - if (item.quality < 50) { - item.quality += 1; - } - } + if (item.sellIn < 6) { + increaseQuality(item); } } + } item.sellIn = item.sellIn - 1; @@ -43,16 +47,12 @@ class GildedRose { if (item.sellIn < 0) { if (!item.name.equals("Aged Brie")) { if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.quality > 0) { - item.quality -= 1; - } + decreaseQuality(item); } else { item.quality -= item.quality; } } else { - if (item.quality < 50) { - item.quality += 1; - } + increaseQuality(item); } } }