OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-19 00:11:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clean up orginal changes

Browse Source
This commit is contained in:
cam millard 2021-12-15 14:06:27 +00:00
parent e818672101
commit 7375bed2c1
1 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
php/src/GildedRose.php
View File

@ -28,17 +28,9 @@ final class GildedRose
*/ */
private $maxQuality = 50; private $maxQuality = 50;
/**
* @var Array
*/
private $itemTypes;
public function __construct(array $items) public function __construct(array $items)
{ {
$this->items = $items; $this->items = $items;
// This could be collected from a database or stored on the item
$this->itemTypes = ['aged', 'conjured', 'backstagePasses', 'legendary'];
} }
public function updateQuality(): void public function updateQuality(): void
@ -72,7 +64,6 @@ final class GildedRose
]; ];
$legendaryRules = []; $legendaryRules = [];
$specialItems = [];
foreach ($this->items as $item) { foreach ($this->items as $item) {
if (isset($ruleItems[$item->name])) { if (isset($ruleItems[$item->name])) {
$ruleArrayName = $ruleItems[$item->name] . "Rules"; $ruleArrayName = $ruleItems[$item->name] . "Rules";
@ -82,25 +73,8 @@ final class GildedRose
if ($item->quality > $this->minQuality) { if ($item->quality > $this->minQuality) {
$item->quality = $item->quality + $this->qualityModifier; $item->quality = $item->quality + $this->qualityModifier;
} }
$item->sell_in = $item->sell_in - 1; $item->sell_in = $item->sell_in - 1;
} }
/*if ($item->quality < 50) {
$item->quality = $item->quality + 1;
if ($item->name == 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->sell_in < 11) {
if ($item->quality < 50) {
$item->quality = $item->quality + 1;
}
}
if ($item->sell_in < 6) {
if ($item->quality < 50) {
$item->quality = $item->quality + 1;
}
}
}
}*/
} }
} }
@ -126,7 +100,6 @@ final class GildedRose
// make sure default is set // make sure default is set
$qualityModifier = $qualityModifier ?? $this->qualityModifier; $qualityModifier = $qualityModifier ?? $this->qualityModifier;
$qualityModifier = ($item->sell_in < 1) ? $qualityModifier * 2: $qualityModifier; $qualityModifier = ($item->sell_in < 1) ? $qualityModifier * 2: $qualityModifier;
$minQuality = $rules['minQuality'] ?? $this->minQuality; $minQuality = $rules['minQuality'] ?? $this->minQuality;