mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-10-14 18:15:41 +00:00
Fix C++ code smells
* Move "using namespace std;" from header to module file (to no longer pollute the global namespace). * Fix inconsistency of having namespace prefix in test code. * Add include guard to GildedRose.h. * Avoid std::endl. * Have consistent white-space.
This commit is contained in:
1 parent
6c59257f27
commit
73a51ef14f
7 files changed
+22
-23
No files matched your search
@@ -3,12 +3,12 @@
|
||||
|
||||
void print_item(Item& item)
|
||||
{
|
||||
std::cout << item.name << ", " << item.sellIn << ", " << item.quality << std::endl;
|
||||
std::cout << item.name << ", " << item.sellIn << ", " << item.quality << '\n';
|
||||
}
|
||||
|
||||
int main()
|
||||
{
|
||||
vector<Item> items;
|
||||
std::vector<Item> items;
|
||||
|
||||
items.push_back({"+5 Dexterity Vest", 10, 20});
|
||||
items.push_back({"Aged Brie", 2, 0});
|
||||
@@ -22,22 +22,20 @@ int main()
|
||||
// this Conjured item doesn't yet work properly
|
||||
items.push_back({"Conjured Mana Cake", 3, 6});
|
||||
|
||||
std::cout << "OMGHAI!" << std::endl;
|
||||
std::cout << "OMGHAI!" << '\n';
|
||||
|
||||
GildedRose app(items);
|
||||
|
||||
for (int day = 0; day <= 30; day++)
|
||||
{
|
||||
std::cout << "-------- day " << day << " --------" << std::endl;
|
||||
std::cout << "name, sellIn, quality" << std::endl;
|
||||
std::cout << "-------- day " << day << " --------" << '\n';
|
||||
std::cout << "name, sellIn, quality" << '\n';
|
||||
for (auto& item : items)
|
||||
{
|
||||
print_item(item);
|
||||
}
|
||||
std::cout << std::endl;
|
||||
std::cout << '\n';
|
||||
app.updateQuality();
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user