OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

breaking down more scopes

Browse Source 
breaking down the Gilded Rose class to several methods for a better approach
This commit is contained in:
Trobax 2022-11-23 16:52:22 +01:00
parent aefb4310a9
commit 7422960de8
1 changed files with 31 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -15,27 +15,9 @@ class GildedRose {
private static void updateItem(Item item) { private static void updateItem(Item item) {
updateQuality(item); updateQuality(item);
updateSelling(item);
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (isExpired(item)) {
item.sellIn--; updateExpired(item);
}
if (item.sellIn < 0) {
if (!item.name.equals("Aged Brie")) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality--;
}
}
} else {
item.quality = 0;
}
} else {
if (item.quality < 50) {
item.quality++;
}
}
} }
} }
@ -67,4 +49,32 @@ class GildedRose {
} }
} }
} }
private static void updateSelling(Item item) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.sellIn--;
}
}
private static boolean isExpired(Item item) {
return item.sellIn < 0;
}
private static void updateExpired(Item item) {
if (!item.name.equals("Aged Brie")) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality--;
}
}
} else {
item.quality = 0;
}
} else {
if (item.quality < 50) {
item.quality++;
}
}
}
} }