OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add handleGenericItem

Browse Source
This commit is contained in:
Richard Xu 2022-12-22 12:41:59 -05:00
parent 5f4dffb5e3
commit 7531e0ead0
3 changed files with 265 additions and 299 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Java/.editorconfig
View File

@ -1,6 +1,6 @@
[*] [*]
charset = utf-8 charset = utf-8
indent_size = 4 indent_size = 2
indent_style = space indent_style = space
insert_final_newline = true insert_final_newline = true
trim_trailing_whitespace = true trim_trailing_whitespace = true

53
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -29,55 +29,20 @@ class GildedRose {
case BACKSTAGE_PASSES: case BACKSTAGE_PASSES:
handleBackstagePasses(item); handleBackstagePasses(item);
return; return;
} default:
if (!item.name.equals(AGED_BRIE) handleGenericItem(item);
&& !item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.name.equals(BACKSTAGE_PASSES)) {
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality = item.quality + 1;
} }
} }
if (item.sellIn < 6) { private static void handleGenericItem(Item item) {
if (item.quality < 50) { if (item.quality == 0) {
item.quality = item.quality + 1; return;
}
}
}
}
}
if (!item.name.equals(SULFURAS)) {
item.sellIn = item.sellIn - 1;
}
if (item.sellIn < 0) {
if (!item.name.equals(AGED_BRIE)) {
if (!item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
} }
item.sellIn -= 1;
if (item.sellIn <= 0) {
item.quality -= 1;
} }
item.quality -= 1;
} }
private static void handleBackstagePasses(Item item) { private static void handleBackstagePasses(Item item) {

3
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -6,6 +6,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
class GildedRoseTest { class GildedRoseTest {
private static final int SULFURAS_QUALITY = 80; private static final int SULFURAS_QUALITY = 80;
@Test @Test
public void agedBrieIncreasesInQualityByOneEachDay() { public void agedBrieIncreasesInQualityByOneEachDay() {
Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 2, 0)}; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 2, 0)};
@ -81,7 +82,7 @@ class GildedRoseTest {
} }
@Test @Test
public void qualityIsNeverNegative() { public void qualityIsNeverNegativeForGenericItems() {
// todo: should add a similar case for conjured // todo: should add a similar case for conjured
int quality = 1; int quality = 1;
Item[] items = new Item[]{new Item("generic item", 5, quality)}; Item[] items = new Item[]{new Item("generic item", 5, quality)};