OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add handleGenericItem

Browse Source
This commit is contained in:
Richard Xu 2022-12-22 12:41:59 -05:00
parent 5f4dffb5e3
commit 7531e0ead0
3 changed files with 265 additions and 299 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Java/.editorconfig
View File

@ -1,6 +1,6 @@
[*] [*]
charset = utf-8 charset = utf-8
indent_size = 4 indent_size = 2
indent_style = space indent_style = space
insert_final_newline = true insert_final_newline = true
trim_trailing_whitespace = true trim_trailing_whitespace = true

53
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -29,55 +29,20 @@ class GildedRose {
case BACKSTAGE_PASSES: case BACKSTAGE_PASSES:
handleBackstagePasses(item); handleBackstagePasses(item);
return; return;
} default:
if (!item.name.equals(AGED_BRIE) handleGenericItem(item);
&& !item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.name.equals(BACKSTAGE_PASSES)) {
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality = item.quality + 1;
} }
} }
if (item.sellIn < 6) { private static void handleGenericItem(Item item) {
if (item.quality < 50) { if (item.quality == 0) {
item.quality = item.quality + 1; return;
}
}
}
}
}
if (!item.name.equals(SULFURAS)) {
item.sellIn = item.sellIn - 1;
}
if (item.sellIn < 0) {
if (!item.name.equals(AGED_BRIE)) {
if (!item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
} }
item.sellIn -= 1;
if (item.sellIn <= 0) {
item.quality -= 1;
} }
item.quality -= 1;
} }
private static void handleBackstagePasses(Item item) { private static void handleBackstagePasses(Item item) {

41
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -6,9 +6,10 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
class GildedRoseTest { class GildedRoseTest {
private static final int SULFURAS_QUALITY = 80; private static final int SULFURAS_QUALITY = 80;
@Test @Test
public void agedBrieIncreasesInQualityByOneEachDay() { public void agedBrieIncreasesInQualityByOneEachDay() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 2, 0) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 2, 0)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 1); assertEquals(app.items.get(0).quality, 1);
@ -19,7 +20,7 @@ class GildedRoseTest {
@Test @Test
public void sulfurasSellInDateNeverChanges() { public void sulfurasSellInDateNeverChanges() {
int sellIn = 10; int sellIn = 10;
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, sellIn, SULFURAS_QUALITY) }; Item[] items = new Item[]{new Item(GildedRose.SULFURAS, sellIn, SULFURAS_QUALITY)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, sellIn); assertEquals(app.items.get(0).sellIn, sellIn);
@ -29,7 +30,7 @@ class GildedRoseTest {
@Test @Test
public void sulfurasValueNeverChanges() { public void sulfurasValueNeverChanges() {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) }; Item[] items = new Item[]{new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, SULFURAS_QUALITY); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
@ -39,7 +40,7 @@ class GildedRoseTest {
@Test @Test
public void sulfurasValueIsAlways80() { public void sulfurasValueIsAlways80() {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) }; Item[] items = new Item[]{new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, SULFURAS_QUALITY); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
@ -48,7 +49,7 @@ class GildedRoseTest {
@Test @Test
public void backstagePassesQualityIncreasesByTwoWhenThereAreTenDaysOrLessBeforeTheConcert() { public void backstagePassesQualityIncreasesByTwoWhenThereAreTenDaysOrLessBeforeTheConcert() {
int quality = 0; int quality = 0;
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 10, quality) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 10, quality)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 2); assertEquals(app.items.get(0).quality, 2);
@ -59,7 +60,7 @@ class GildedRoseTest {
@Test @Test
public void backstagePassesQualityIncreasesByThreeWhenThereAreFiveDaysOrLessBeforeTheConcert() { public void backstagePassesQualityIncreasesByThreeWhenThereAreFiveDaysOrLessBeforeTheConcert() {
int quality = 0; int quality = 0;
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, quality) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 5, quality)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 3); assertEquals(app.items.get(0).quality, 3);
@ -72,7 +73,7 @@ class GildedRoseTest {
@Test @Test
public void backstagePassesQualityDropsToZeroAfterTheConcert() { public void backstagePassesQualityDropsToZeroAfterTheConcert() {
int quality = 10; int quality = 10;
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 1, quality) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 1, quality)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 13); assertEquals(app.items.get(0).quality, 13);
@ -81,10 +82,10 @@ class GildedRoseTest {
} }
@Test @Test
public void qualityIsNeverNegative() { public void qualityIsNeverNegativeForGenericItems() {
// todo: should add a similar case for conjured // todo: should add a similar case for conjured
int quality = 1; int quality = 1;
Item[] items = new Item[] { new Item("generic item", 5, quality) }; Item[] items = new Item[]{new Item("generic item", 5, quality)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 0); assertEquals(app.items.get(0).quality, 0);
@ -96,7 +97,7 @@ class GildedRoseTest {
@Test @Test
public void qualityIsNeverOverFiftyForAgedBrie() { public void qualityIsNeverOverFiftyForAgedBrie() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 50) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 5, 50)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 50);
@ -108,7 +109,7 @@ class GildedRoseTest {
@Test @Test
public void qualityIsNeverOverFiftyForBackstagePasses() { public void qualityIsNeverOverFiftyForBackstagePasses() {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 50) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 5, 50)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 50);
@ -120,7 +121,7 @@ class GildedRoseTest {
@Test @Test
public void qualityDecreasesByOneEachDayForGenericItems() { public void qualityDecreasesByOneEachDayForGenericItems() {
Item[] items = new Item[] { new Item("generic item", 5, 5) }; Item[] items = new Item[]{new Item("generic item", 5, 5)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 4); assertEquals(app.items.get(0).quality, 4);
@ -132,7 +133,7 @@ class GildedRoseTest {
@Test @Test
public void qualityDecreasesByTwoEachDayForGenericItemsAfterSellInDate() { public void qualityDecreasesByTwoEachDayForGenericItemsAfterSellInDate() {
Item[] items = new Item[] { new Item("generic item", 1, 6) }; Item[] items = new Item[]{new Item("generic item", 1, 6)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 5); assertEquals(app.items.get(0).quality, 5);
@ -144,7 +145,7 @@ class GildedRoseTest {
@Test @Test
public void sellInDateDecreasesByOneEachDayForAgedBrie() { public void sellInDateDecreasesByOneEachDayForAgedBrie() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 1) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 5, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
@ -156,7 +157,7 @@ class GildedRoseTest {
@Test @Test
public void sellInDateDecreasesByOneEachDayForBackstagePasses() { public void sellInDateDecreasesByOneEachDayForBackstagePasses() {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 1) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 5, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
@ -168,7 +169,7 @@ class GildedRoseTest {
@Test @Test
public void sellInDateDecreasesByOneEachDayForGenericItems() { public void sellInDateDecreasesByOneEachDayForGenericItems() {
Item[] items = new Item[] { new Item("generic item", 5, 1) }; Item[] items = new Item[]{new Item("generic item", 5, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
@ -180,7 +181,7 @@ class GildedRoseTest {
@Test @Test
public void sellInDateCanBeNegativeForGenericItems() { public void sellInDateCanBeNegativeForGenericItems() {
Item[] items = new Item[] { new Item("generic item", 1, 1) }; Item[] items = new Item[]{new Item("generic item", 1, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 0); assertEquals(app.items.get(0).sellIn, 0);
@ -192,7 +193,7 @@ class GildedRoseTest {
@Test @Test
public void sellInDateCanBeNegativeForAgedBrie() { public void sellInDateCanBeNegativeForAgedBrie() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 1, 1) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 1, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 0); assertEquals(app.items.get(0).sellIn, 0);
@ -204,7 +205,7 @@ class GildedRoseTest {
@Test @Test
public void sellInDateCanBeNegativeForBackStagePasses() { public void sellInDateCanBeNegativeForBackStagePasses() {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 1, 1) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 1, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 0); assertEquals(app.items.get(0).sellIn, 0);
@ -216,7 +217,7 @@ class GildedRoseTest {
@Test @Test
public void itUpdatesAllItemsPassedIn() { public void itUpdatesAllItemsPassedIn() {
Item[] items = new Item[] { Item[] items = new Item[]{
new Item("generic item 1", 5, 5), new Item("generic item 1", 5, 5),
new Item("generic item 2", 5, 10) new Item("generic item 2", 5, 10)
}; };