OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add handleGenericItem

Browse Source
This commit is contained in:
Richard Xu 2022-12-22 12:41:59 -05:00
parent 5f4dffb5e3
commit 7531e0ead0
3 changed files with 265 additions and 299 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Java/.editorconfig
View File

@ -1,6 +1,6 @@
[*] [*]
charset = utf-8 charset = utf-8
indent_size = 4 indent_size = 2
indent_style = space indent_style = space
insert_final_newline = true insert_final_newline = true
trim_trailing_whitespace = true trim_trailing_whitespace = true

145
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -4,105 +4,70 @@ import java.util.Arrays;
import java.util.List; import java.util.List;
class GildedRose { class GildedRose {
public static final String AGED_BRIE = "Aged Brie"; public static final String AGED_BRIE = "Aged Brie";
public static final String SULFURAS = "Sulfuras, Hand of Ragnaros"; public static final String SULFURAS = "Sulfuras, Hand of Ragnaros";
public static final String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert"; public static final String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert";
final List<Item> items; final List<Item> items;
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
this.items = Arrays.asList(items); this.items = Arrays.asList(items);
}
public void updateQuality() {
items.forEach(GildedRose::handleDay);
}
private static void handleDay(Item item) {
switch (item.name) {
case AGED_BRIE:
handleAgedBrie(item);
return;
case SULFURAS:
handleSulfuras(item);
return;
case BACKSTAGE_PASSES:
handleBackstagePasses(item);
return;
default:
handleGenericItem(item);
} }
}
public void updateQuality() { private static void handleGenericItem(Item item) {
items.forEach(GildedRose::handleDay); if (item.quality == 0) {
return;
} }
item.sellIn -= 1;
private static void handleDay(Item item) { if (item.sellIn <= 0) {
switch (item.name) { item.quality -= 1;
case AGED_BRIE:
handleAgedBrie(item);
return;
case SULFURAS:
handleSulfuras(item);
return;
case BACKSTAGE_PASSES:
handleBackstagePasses(item);
return;
}
if (!item.name.equals(AGED_BRIE)
&& !item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.name.equals(BACKSTAGE_PASSES)) {
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < 6) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
}
}
}
if (!item.name.equals(SULFURAS)) {
item.sellIn = item.sellIn - 1;
}
if (item.sellIn < 0) {
if (!item.name.equals(AGED_BRIE)) {
if (!item.name.equals(BACKSTAGE_PASSES)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
}
} }
item.quality -= 1;
}
private static void handleBackstagePasses(Item item) { private static void handleBackstagePasses(Item item) {
// todo: make it so these items can't be initialized with over 50 // todo: make it so these items can't be initialized with over 50
if (item.quality == 50) { if (item.quality == 50) {
return; return;
}
if (item.sellIn == 0) {
item.quality = 0;
} else if (item.sellIn <= 5) {
item.quality += 3;
} else if (item.sellIn <= 10) {
item.quality += 2;
}
item.sellIn -= 1;
} }
if (item.sellIn == 0) {
private static void handleSulfuras(Item item) { item.quality = 0;
} else if (item.sellIn <= 5) {
item.quality += 3;
} else if (item.sellIn <= 10) {
item.quality += 2;
} }
item.sellIn -= 1;
}
private static void handleAgedBrie(Item item) { private static void handleSulfuras(Item item) {
if (item.quality != 50) {
item.quality += 1; }
}
item.sellIn -= 1; private static void handleAgedBrie(Item item) {
if (item.quality != 50) {
item.quality += 1;
} }
item.sellIn -= 1;
}
} }

417
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -5,230 +5,231 @@ import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
class GildedRoseTest { class GildedRoseTest {
private static final int SULFURAS_QUALITY = 80; private static final int SULFURAS_QUALITY = 80;
@Test
public void agedBrieIncreasesInQualityByOneEachDay() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 2, 0) };
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals(app.items.get(0).quality, 1);
app.updateQuality();
assertEquals(app.items.get(0).quality, 2);
}
@Test @Test
public void sulfurasSellInDateNeverChanges() { public void agedBrieIncreasesInQualityByOneEachDay() {
int sellIn = 10; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 2, 0)};
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, sellIn, SULFURAS_QUALITY) }; GildedRose app = new GildedRose(items);
GildedRose app = new GildedRose(items); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).quality, 1);
assertEquals(app.items.get(0).sellIn, sellIn); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).quality, 2);
assertEquals(app.items.get(0).sellIn, sellIn); }
}
@Test @Test
public void sulfurasValueNeverChanges() { public void sulfurasSellInDateNeverChanges() {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) }; int sellIn = 10;
GildedRose app = new GildedRose(items); Item[] items = new Item[]{new Item(GildedRose.SULFURAS, sellIn, SULFURAS_QUALITY)};
app.updateQuality(); GildedRose app = new GildedRose(items);
assertEquals(app.items.get(0).quality, SULFURAS_QUALITY); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).sellIn, sellIn);
assertEquals(app.items.get(0).quality, SULFURAS_QUALITY); app.updateQuality();
} assertEquals(app.items.get(0).sellIn, sellIn);
}
@Test @Test
public void sulfurasValueIsAlways80() { public void sulfurasValueNeverChanges() {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) }; Item[] items = new Item[]{new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, SULFURAS_QUALITY); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
} app.updateQuality();
assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
}
@Test @Test
public void backstagePassesQualityIncreasesByTwoWhenThereAreTenDaysOrLessBeforeTheConcert() { public void sulfurasValueIsAlways80() {
int quality = 0; Item[] items = new Item[]{new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY)};
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 10, quality) }; GildedRose app = new GildedRose(items);
GildedRose app = new GildedRose(items); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
assertEquals(app.items.get(0).quality, 2); }
app.updateQuality();
assertEquals(app.items.get(0).quality, 4);
}
@Test @Test
public void backstagePassesQualityIncreasesByThreeWhenThereAreFiveDaysOrLessBeforeTheConcert() { public void backstagePassesQualityIncreasesByTwoWhenThereAreTenDaysOrLessBeforeTheConcert() {
int quality = 0; int quality = 0;
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, quality) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 10, quality)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 3); assertEquals(app.items.get(0).quality, 2);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 6); assertEquals(app.items.get(0).quality, 4);
app.updateQuality(); }
assertEquals(app.items.get(0).quality, 9);
}
@Test @Test
public void backstagePassesQualityDropsToZeroAfterTheConcert() { public void backstagePassesQualityIncreasesByThreeWhenThereAreFiveDaysOrLessBeforeTheConcert() {
int quality = 10; int quality = 0;
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 1, quality) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 5, quality)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 13); assertEquals(app.items.get(0).quality, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 0); assertEquals(app.items.get(0).quality, 6);
} app.updateQuality();
assertEquals(app.items.get(0).quality, 9);
}
@Test @Test
public void qualityIsNeverNegative() { public void backstagePassesQualityDropsToZeroAfterTheConcert() {
// todo: should add a similar case for conjured int quality = 10;
int quality = 1; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 1, quality)};
Item[] items = new Item[] { new Item("generic item", 5, quality) }; GildedRose app = new GildedRose(items);
GildedRose app = new GildedRose(items); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).quality, 13);
assertEquals(app.items.get(0).quality, 0); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).quality, 0);
assertEquals(app.items.get(0).quality, 0); }
app.updateQuality();
assertEquals(app.items.get(0).quality, 0);
}
@Test @Test
public void qualityIsNeverOverFiftyForAgedBrie() { public void qualityIsNeverNegativeForGenericItems() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 50) }; // todo: should add a similar case for conjured
GildedRose app = new GildedRose(items); int quality = 1;
app.updateQuality(); Item[] items = new Item[]{new Item("generic item", 5, quality)};
assertEquals(app.items.get(0).quality, 50); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 0);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 0);
} app.updateQuality();
assertEquals(app.items.get(0).quality, 0);
}
@Test @Test
public void qualityIsNeverOverFiftyForBackstagePasses() { public void qualityIsNeverOverFiftyForAgedBrie() {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 50) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 5, 50)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 50); assertEquals(app.items.get(0).quality, 50);
} }
@Test @Test
public void qualityDecreasesByOneEachDayForGenericItems() { public void qualityIsNeverOverFiftyForBackstagePasses() {
Item[] items = new Item[] { new Item("generic item", 5, 5) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 5, 50)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 4); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 3); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 2); assertEquals(app.items.get(0).quality, 50);
} }
@Test @Test
public void qualityDecreasesByTwoEachDayForGenericItemsAfterSellInDate() { public void qualityDecreasesByOneEachDayForGenericItems() {
Item[] items = new Item[] { new Item("generic item", 1, 6) }; Item[] items = new Item[]{new Item("generic item", 5, 5)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 5); assertEquals(app.items.get(0).quality, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 3); assertEquals(app.items.get(0).quality, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).quality, 1); assertEquals(app.items.get(0).quality, 2);
} }
@Test @Test
public void sellInDateDecreasesByOneEachDayForAgedBrie() { public void qualityDecreasesByTwoEachDayForGenericItemsAfterSellInDate() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 1) }; Item[] items = new Item[]{new Item("generic item", 1, 6)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 4); assertEquals(app.items.get(0).quality, 5);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 3); assertEquals(app.items.get(0).quality, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 2); assertEquals(app.items.get(0).quality, 1);
} }
@Test @Test
public void sellInDateDecreasesByOneEachDayForBackstagePasses() { public void sellInDateDecreasesByOneEachDayForAgedBrie() {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 1) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 5, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 3); assertEquals(app.items.get(0).sellIn, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 2); assertEquals(app.items.get(0).sellIn, 2);
} }
@Test @Test
public void sellInDateDecreasesByOneEachDayForGenericItems() { public void sellInDateDecreasesByOneEachDayForBackstagePasses() {
Item[] items = new Item[] { new Item("generic item", 5, 1) }; Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 5, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 3); assertEquals(app.items.get(0).sellIn, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 2); assertEquals(app.items.get(0).sellIn, 2);
} }
@Test @Test
public void sellInDateCanBeNegativeForGenericItems() { public void sellInDateDecreasesByOneEachDayForGenericItems() {
Item[] items = new Item[] { new Item("generic item", 1, 1) }; Item[] items = new Item[]{new Item("generic item", 5, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 0); assertEquals(app.items.get(0).sellIn, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, -1); assertEquals(app.items.get(0).sellIn, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, -2); assertEquals(app.items.get(0).sellIn, 2);
} }
@Test @Test
public void sellInDateCanBeNegativeForAgedBrie() { public void sellInDateCanBeNegativeForGenericItems() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 1, 1) }; Item[] items = new Item[]{new Item("generic item", 1, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 0); assertEquals(app.items.get(0).sellIn, 0);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, -1); assertEquals(app.items.get(0).sellIn, -1);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, -2); assertEquals(app.items.get(0).sellIn, -2);
} }
@Test @Test
public void sellInDateCanBeNegativeForBackStagePasses() { public void sellInDateCanBeNegativeForAgedBrie() {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 1, 1) }; Item[] items = new Item[]{new Item(GildedRose.AGED_BRIE, 1, 1)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, 0); assertEquals(app.items.get(0).sellIn, 0);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, -1); assertEquals(app.items.get(0).sellIn, -1);
app.updateQuality(); app.updateQuality();
assertEquals(app.items.get(0).sellIn, -2); assertEquals(app.items.get(0).sellIn, -2);
} }
@Test @Test
public void itUpdatesAllItemsPassedIn() { public void sellInDateCanBeNegativeForBackStagePasses() {
Item[] items = new Item[] { Item[] items = new Item[]{new Item(GildedRose.BACKSTAGE_PASSES, 1, 1)};
new Item("generic item 1", 5, 5), GildedRose app = new GildedRose(items);
new Item("generic item 2", 5, 10) app.updateQuality();
}; assertEquals(app.items.get(0).sellIn, 0);
GildedRose app = new GildedRose(items); app.updateQuality();
app.updateQuality(); assertEquals(app.items.get(0).sellIn, -1);
assertEquals(app.items.get(0).quality, 4); app.updateQuality();
assertEquals(app.items.get(1).quality, 9); assertEquals(app.items.get(0).sellIn, -2);
app.updateQuality(); }
assertEquals(app.items.get(0).quality, 3);
assertEquals(app.items.get(1).quality, 8); @Test
app.updateQuality(); public void itUpdatesAllItemsPassedIn() {
assertEquals(app.items.get(0).quality, 2); Item[] items = new Item[]{
assertEquals(app.items.get(1).quality, 7); new Item("generic item 1", 5, 5),
} new Item("generic item 2", 5, 10)
};
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals(app.items.get(0).quality, 4);
assertEquals(app.items.get(1).quality, 9);
app.updateQuality();
assertEquals(app.items.get(0).quality, 3);
assertEquals(app.items.get(1).quality, 8);
app.updateQuality();
assertEquals(app.items.get(0).quality, 2);
assertEquals(app.items.get(1).quality, 7);
}
} }