From 757759617159729b51e2cb0bfb02c6948999feea Mon Sep 17 00:00:00 2001 From: Chamoda Ranasinghe Date: Tue, 16 Jan 2024 03:33:11 +0700 Subject: [PATCH] cleaned up updateBackstagePassesItem method asserted ItemNames.BACKSTAGE_PASSES --- TypeScript/app/gilded-rose.ts | 40 +++++++---------------------------- 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/TypeScript/app/gilded-rose.ts b/TypeScript/app/gilded-rose.ts index 06fa865f..df7459a9 100644 --- a/TypeScript/app/gilded-rose.ts +++ b/TypeScript/app/gilded-rose.ts @@ -34,27 +34,15 @@ export class GildedRose { } private updateBackstagePassesItem(item: Item) { - if ( - item.name != ItemNames.AGED_BRIE && - item.name != ItemNames.BACKSTAGE_PASSES - ) { - if (item.quality > 0) { - if (item.name != ItemNames.SULFURAS) { - item.quality = item.quality - 1; - } - } - } else if (item.quality < MAX_ITEM_QUALITY) { + assert(item.name == ItemNames.BACKSTAGE_PASSES); + if (item.quality < MAX_ITEM_QUALITY) { item.quality = item.quality + 1; - if (item.name == ItemNames.BACKSTAGE_PASSES) { - if (item.sellIn < 11) { - if (item.quality < MAX_ITEM_QUALITY) { - item.quality = item.quality + 1; - } + if (item.name == ItemNames.BACKSTAGE_PASSES && item.sellIn < 11) { + if (item.sellIn < 11 && item.quality < MAX_ITEM_QUALITY) { + item.quality = item.quality + 1; } - if (item.sellIn < 6) { - if (item.quality < MAX_ITEM_QUALITY) { - item.quality = item.quality + 1; - } + if (item.sellIn < 6 && item.quality < MAX_ITEM_QUALITY) { + item.quality = item.quality + 1; } } } @@ -62,19 +50,7 @@ export class GildedRose { item.sellIn = item.sellIn - 1; } if (item.sellIn < 0) { - if (item.name != ItemNames.AGED_BRIE) { - if (item.name != ItemNames.BACKSTAGE_PASSES) { - if (item.quality > 0) { - if (item.name != ItemNames.SULFURAS) { - item.quality = item.quality - 1; - } - } - } else { - item.quality = 0; - } - } else if (item.quality < MAX_ITEM_QUALITY) { - item.quality = item.quality + 1; - } + item.quality = 0; } }