OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: remove mutation methods now and cut-up the switch cases

Browse Source
This commit is contained in:
Kadir Sirimsi 2025-02-10 16:30:54 +01:00
parent 541c817175
commit 7662217d87
No known key found for this signature in database
GPG Key ID: A21C0144C2D2A134
1 changed files with 40 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

97
Java/src/main/java/com/gildedrose/Item.java
View File

@ -27,70 +27,53 @@ public class Item {
public void updateItem() { public void updateItem() {
switch (type) { switch (type) {
case AgedBrie -> { case AgedBrie -> updateAgedBrieItem();
case BackstagePass -> updateBackstagePassItem();
if (quality < 50) {
addOneToQuality();
}
deductSellIn();
if (sellIn < 0 && quality < 50) {
addOneToQuality();
}
}
case BackstagePass -> {
if (quality < 50) {
addOneToQuality();
}
if (sellIn < 11 && quality < 50) {
addOneToQuality();
}
if (sellIn < 6 && quality < 50) {
addOneToQuality();
}
deductSellIn();
if (sellIn < 0) {
quality = 0;
}
}
case Sulfuras -> {} case Sulfuras -> {}
case Unknown -> updateUnknownItem();
case Unknown -> {
deductSellIn();
if (quality > 0) {
deductOneFromQuality();
}
if (sellIn < 0 && quality > 0) {
deductOneFromQuality();
}
}
} }
} }
private void setQualityToZero() { private void updateUnknownItem() {
quality = 0;
}
private void deductSellIn() {
sellIn--; sellIn--;
}
private void addOneToQuality() { if (quality > 0) {
quality++; quality--;
} }
private void deductOneFromQuality() { if (sellIn < 0 && quality > 0) {
quality--; quality--;
}
}
private void updateBackstagePassItem() {
if (quality < 50) {
quality++;
}
if (sellIn < 11 && quality < 50) {
quality++;
}
if (sellIn < 6 && quality < 50) {
quality++;
}
sellIn--;
if (sellIn < 0) {
quality = 0;
}
}
public void updateAgedBrieItem() {
if (quality < 50) {
quality++;
}
sellIn--;
if (sellIn < 0 && quality < 50) {
quality++;
}
} }
@Override @Override