OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactored GildedRose code, Modified the updateQuality method to handle 'Conjured' items more efficiently

Browse Source
This commit is contained in:
Sriramachandran Sitharaman 2024-02-21 11:55:02 +05:30
parent 2a2770b10d
commit 77826ba5bf
1 changed files with 68 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,5 +1,7 @@
package com.gildedrose; package com.gildedrose;
import java.util.Arrays;
class GildedRose { class GildedRose {
Item[] items; Item[] items;
@ -8,55 +10,75 @@ class GildedRose {
} }
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { Arrays.stream(items).forEach(this::updateItemQuality);
if (!items[i].name.equals("Aged Brie") }
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { private void updateItemQuality(Item item) {
if (items[i].sellIn < 11) { switch (item.name) {
if (items[i].quality < 50) { case "Aged Brie":
items[i].quality = items[i].quality + 1; increaseQuality(item);
} break;
} case "Backstage passes to a TAFKAL80ETC concert":
handleBackstagePass(item);
break;
case "Sulfuras, Hand of Ragnaros":
// Legendary item, no changes needed
break;
case "Conjured":
decreaseQuality(item, 2);
break;
default:
decreaseQuality(item);
break;
}
if (items[i].sellIn < 6) { if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
if (items[i].quality < 50) { item.sellIn -= 1;
items[i].quality = items[i].quality + 1; }
}
} if (item.sellIn < 0) {
} handleExpiredItem(item);
} }
}
private void increaseQuality(Item item) {
if (item.quality < 50) {
item.quality += 1;
}
}
private void decreaseQuality(Item item) {
if (item.quality > 0) {
item.quality -= 1;
}
}
private void decreaseQuality(Item item, int factor) {
item.quality = Math.max(0, item.quality - factor);
}
private void handleBackstagePass(Item item) {
if (item.quality < 50) {
item.quality += 1;
if (item.sellIn < 11) {
increaseQuality(item);
} }
if (item.sellIn < 6) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { increaseQuality(item);
items[i].sellIn = items[i].sellIn - 1;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
} }
} }
} }
private void handleExpiredItem(Item item) {
if (!item.name.equals("Aged Brie") && !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
decreaseQuality(item);
if (item.name.equals("Conjured")) {
decreaseQuality(item, 1); // Additional decrease for Conjured items
}
}
} else {
item.quality = 0;
}
}
} }