OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract names in columns

Browse Source
This commit is contained in:
Remus Decea 2023-11-10 13:40:44 +02:00
parent ef182d14ac
commit 799b9f26d6
2 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -3,16 +3,19 @@ package com.gildedrose;
class GildedRose { class GildedRose {
Item[] items; Item[] items;
public static String backStagePasses = "Backstage passes to a TAFKAL80ETC concert";
public static String sulfuras = "Sulfuras, Hand of Ragnaros";
public static String agedBrie = "Aged Brie";
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
this.items = items; this.items = items;
} }
public void updateQuality() { public void updateQuality() {
for (Item item : items) { for (Item item : items) {
if (!item.name.equals("Aged Brie") if (!item.name.equals(agedBrie) && !item.name.equals(backStagePasses)) {
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) { if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (!item.name.equals(sulfuras)) {
item.quality = item.quality - 1; item.quality = item.quality - 1;
} }
} }
@ -20,7 +23,7 @@ class GildedRose {
if (item.quality < 50) { if (item.quality < 50) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (item.name.equals(backStagePasses)) {
if (item.sellIn < 11) { if (item.sellIn < 11) {
if (item.quality < 50) { if (item.quality < 50) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
@ -36,15 +39,15 @@ class GildedRose {
} }
} }
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (!item.name.equals(sulfuras)) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (item.sellIn < 0) { if (item.sellIn < 0) {
if (!item.name.equals("Aged Brie")) { if (!item.name.equals(agedBrie)) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!item.name.equals(backStagePasses)) {
if (item.quality > 0) { if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (!item.name.equals(sulfuras)) {
item.quality = item.quality - 1; item.quality = item.quality - 1;
} }
} }

4
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -80,7 +80,7 @@ class GildedRoseTest {
void sulfurasNeverDecreases(){ void sulfurasNeverDecreases(){
//TODO: Sulfuras should be protected against instantiation with quality != 80 //TODO: Sulfuras should be protected against instantiation with quality != 80
Item[] items = new Item[]{ Item[] items = new Item[]{
new Item("Sulfuras, Hand of Ragnaros", 100, 80) new Item(GildedRose.sulfuras, 100, 80)
}; };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
@ -90,7 +90,7 @@ class GildedRoseTest {
@Test @Test
void backStagePassesIncrease() { void backStagePassesIncrease() {
String backstage = "Backstage passes to a TAFKAL80ETC concert"; String backstage = GildedRose.backStagePasses;
Item[] items = new Item[]{ Item[] items = new Item[]{
new Item(backstage, 100, 0), new Item(backstage, 100, 0),
new Item(backstage, 11, 0), new Item(backstage, 11, 0),