From 7a609b11f126b5a842a654f0f43275911a2b1d6f Mon Sep 17 00:00:00 2001
From: Velizar Todorov <velizar.todorov@unifiedpost.com>
Date: Tue, 30 Nov 2021 18:05:20 +0100
Subject: [PATCH] :white_check_mark: improve unit tests

---
 .../java/com/gildedrose/items/AgedBrieItemTest.java  | 10 ++++++++--
 .../com/gildedrose/items/BackstagePassItemTest.java  | 12 +++++++++---
 .../java/com/gildedrose/items/ConjuredItemTest.java  | 10 ++++++++--
 3 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/src/test/java/com/gildedrose/items/AgedBrieItemTest.java b/src/test/java/com/gildedrose/items/AgedBrieItemTest.java
index b950046f..e92f8c55 100644
--- a/src/test/java/com/gildedrose/items/AgedBrieItemTest.java
+++ b/src/test/java/com/gildedrose/items/AgedBrieItemTest.java
@@ -6,8 +6,7 @@ import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestMethodOrder;
 
-import static com.gildedrose.helper.TestHelper.testItem;
-import static com.gildedrose.helper.TestHelper.testItemException;
+import static com.gildedrose.helper.TestHelper.*;
 import static com.gildedrose.items.AgedBrieItem.AGED_BRIE;
 
 @TestMethodOrder(OrderAnnotation.class)
@@ -15,6 +14,7 @@ class AgedBrieItemTest {
 
   private final Item item = new Item(AGED_BRIE, 5, 20);
   private final Item itemError = new Item(AGED_BRIE, 10, -5);
+  private final Item itemAboveLimitQuality = new Item(AGED_BRIE, 10, 60);
 
   @Test
   @Order(1)
@@ -34,4 +34,10 @@ class AgedBrieItemTest {
     testItemException(itemError);
   }
 
+  @Test
+  @Order(4)
+  void QualityAboveLimitFail() {
+    testItemQualityAboveLimitException(itemAboveLimitQuality);
+  }
+
 }
diff --git a/src/test/java/com/gildedrose/items/BackstagePassItemTest.java b/src/test/java/com/gildedrose/items/BackstagePassItemTest.java
index cd4f59d9..fd2506e4 100644
--- a/src/test/java/com/gildedrose/items/BackstagePassItemTest.java
+++ b/src/test/java/com/gildedrose/items/BackstagePassItemTest.java
@@ -6,8 +6,7 @@ import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestMethodOrder;
 
-import static com.gildedrose.helper.TestHelper.testItem;
-import static com.gildedrose.helper.TestHelper.testItemException;
+import static com.gildedrose.helper.TestHelper.*;
 import static com.gildedrose.items.BackstagePassItem.BACKSTAGE_PASS;
 
 @TestMethodOrder(OrderAnnotation.class)
@@ -15,6 +14,7 @@ class BackstagePassItemTest {
 
   private final Item item = new Item(BACKSTAGE_PASS, 15, 20);
   private final Item itemError = new Item(BACKSTAGE_PASS, 10, -5);
+  private final Item itemAboveLimitQuality = new Item(BACKSTAGE_PASS, 10, 60);
 
   @Test
   @Order(1)
@@ -41,9 +41,15 @@ class BackstagePassItemTest {
   }
 
   @Test
-  @Order(2)
+  @Order(5)
   void negativeQualityFail() {
     testItemException(itemError);
   }
 
+  @Test
+  @Order(6)
+  void QualityAboveLimitFail() {
+    testItemQualityAboveLimitException(itemAboveLimitQuality);
+  }
+
 }
diff --git a/src/test/java/com/gildedrose/items/ConjuredItemTest.java b/src/test/java/com/gildedrose/items/ConjuredItemTest.java
index 8cf64a97..e4a2b9ff 100644
--- a/src/test/java/com/gildedrose/items/ConjuredItemTest.java
+++ b/src/test/java/com/gildedrose/items/ConjuredItemTest.java
@@ -6,8 +6,7 @@ import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestMethodOrder;
 
-import static com.gildedrose.helper.TestHelper.testItem;
-import static com.gildedrose.helper.TestHelper.testItemException;
+import static com.gildedrose.helper.TestHelper.*;
 import static com.gildedrose.items.ConjuredItem.CONJURED;
 
 @TestMethodOrder(OrderAnnotation.class)
@@ -15,6 +14,7 @@ class ConjuredItemTest {
 
   private final Item item = new Item(CONJURED, 5, 20);
   private final Item itemError = new Item(CONJURED, 10, -5);
+  private final Item itemAboveLimitQuality = new Item(CONJURED, 10, 60);
 
   @Test
   @Order(1)
@@ -33,4 +33,10 @@ class ConjuredItemTest {
   void negativeQualityFail() {
     testItemException(itemError);
   }
+
+  @Test
+  @Order(4)
+  void QualityAboveLimitFail() {
+    testItemQualityAboveLimitException(itemAboveLimitQuality);
+  }
 }