From 7b0e2daa3d745e77f3f4768fd980a7e510cb9428 Mon Sep 17 00:00:00 2001 From: Gabba Date: Thu, 11 Jan 2018 12:32:00 +0000 Subject: [PATCH] moves lowest quality value --- Java/src/main/java/com/gildedrose/GildedRose.java | 5 ++--- Java/src/main/java/com/gildedrose/item/QualityValues.java | 4 ++++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index b2be1de8..596856f7 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -7,7 +7,6 @@ import com.gildedrose.item.QualityValues; class GildedRose { - private static final int LOWEST_QUALITY_VALUE_POSSIBLE = 0; Item[] items; public GildedRose(Item[] items) { @@ -18,7 +17,7 @@ class GildedRose { for (Item item : items) { customisedItem(item).updateState(); if (hasReachedLowestQualityValue(item)) { - item.quality = LOWEST_QUALITY_VALUE_POSSIBLE; + item.quality = QualityValues.lowestValuePossible(); } else if (hasReachedHighestQualityValue(item)) { item.quality = QualityValues.highestValuePossible(item); } @@ -30,7 +29,7 @@ class GildedRose { } private boolean hasReachedLowestQualityValue(Item item) { - return item.quality < LOWEST_QUALITY_VALUE_POSSIBLE; + return item.quality < QualityValues.lowestValuePossible(); } private boolean hasReachedHighestQualityValue(Item item) { diff --git a/Java/src/main/java/com/gildedrose/item/QualityValues.java b/Java/src/main/java/com/gildedrose/item/QualityValues.java index 83ab044b..cc4d52a3 100644 --- a/Java/src/main/java/com/gildedrose/item/QualityValues.java +++ b/Java/src/main/java/com/gildedrose/item/QualityValues.java @@ -2,6 +2,10 @@ package com.gildedrose.item; public final class QualityValues { + public static int lowestValuePossible() { + return 0; + } + public static int highestValuePossible(Item item) { if (item.name.equals(CustomisedItemFactory.SULFURAS)) { return 80;