OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2 from Decker-Matthew-R/Decker-Refactor-Branch

Browse Source 
Refactoring update item quality method
This commit is contained in:
Matt Decker 2022-07-02 09:08:25 -05:00 committed by GitHub
commit 7d271910c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -9,57 +9,62 @@ class GildedRose {
} }
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (Item item : items) {
if (!items[i].name.equals("Aged Brie") updateItemQuality(item);
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { }
if (items[i].quality > 0) { }
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1; private void updateItemQuality(Item item) {
if (!item.name.equals("Aged Brie")
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1;
} }
} }
} else { } else {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) { if (item.sellIn < 11) {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
} }
} }
if (items[i].sellIn < 6) { if (item.sellIn < 6) {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
} }
} }
} }
} }
} }
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (items[i].sellIn < 0) { if (item.sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) { if (!item.name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { if (item.quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1; item.quality = item.quality - 1;
} }
} }
} else { } else {
items[i].quality = items[i].quality - items[i].quality; item.quality = item.quality - item.quality;
} }
} else { } else {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
} }
} }
} }
} }
}
public Item[] getItems() { public Item[] getItems() {
return items; return items;