Add agedBrieIncreasesInQualityByOneEachDay

This commit is contained in:
Richard Xu 2022-12-22 11:25:00 -05:00
parent 7397b893f9
commit 80020675b5
5 changed files with 61 additions and 9 deletions

4
Java/approach.md Normal file
View File

@ -0,0 +1,4 @@
# Approach
1. I'm first going to write all of the tests for the class
2. Then I'm going to refactor

48
Java/requirements.md Normal file
View File

@ -0,0 +1,48 @@
======================================
Gilded Rose Requirements Specification
======================================
Hi and welcome to team Gilded Rose. As you know, we are a small inn with a prime location in a
prominent city ran by a friendly innkeeper named Allison. We also buy and sell only the finest goods.
Unfortunately, our goods are constantly degrading in quality as they approach their sell by date. We
have a system in place that updates our inventory for us. It was developed by a no-nonsense type named
Leeroy, who has moved on to new adventures. Your task is to add the new feature to our system so that
we can begin selling a new category of items. First an introduction to our system:
- All items have a `SellIn` value which denotes the number of days we have to sell the item
- All items have a `Quality` value which denotes how valuable the item is
- At the end of each day our system lowers both values for every item
Pretty simple, right? Well this is where it gets interesting:
[//]: # (- Once the sell by date has passed, `Quality` degrades twice as fast)
[//]: # (- The `Quality` of an item is never negative)
[//]: # (- "Aged Brie" actually increases in `Quality` the older it gets)
[//]: # (- The `Quality` of an item is never more than 50)
[//]: # (- "Sulfuras", being a legendary item, never has to be sold or decreases in `Quality`)
[//]: # (- "Backstage passes", like aged brie, increases in `Quality` as its `SellIn` value approaches;)
[//]: # ( `Quality` increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but)
[//]: # ( `Quality` drops to 0 after the concert)
We have recently signed a supplier of conjured items. This requires an update to our system:
- "Conjured" items degrade in `Quality` twice as fast as normal items
Feel free to make any changes to the `updateQuality` method and add any new code as long as everything
still works correctly. However, do not alter the Item class or Items property as those belong to the
goblin in the corner who will insta-rage and one-shot you as he doesn't believe in shared code
ownership (you can make the `updateQuality` method and Items property static if you like, we'll cover
for you).
Just for clarification, an item can never have its `Quality` increase above 50, however "Sulfuras" is a
legendary item and as such its `Quality` is 80 and it never alters.
---
My Requirements understanding:
What are the

View File

@ -1,6 +1,7 @@
package com.gildedrose;
class GildedRose {
public static final String AGED_BRIE = "Aged Brie";
Item[] items;
public GildedRose(Item[] items) {
@ -9,7 +10,7 @@ class GildedRose {
public void updateQuality() {
for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie")
if (!items[i].name.equals(AGED_BRIE)
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
@ -41,7 +42,7 @@ class GildedRose {
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals(AGED_BRIE)) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
@ -59,4 +60,4 @@ class GildedRose {
}
}
}
}
}

View File

@ -7,11 +7,12 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
class GildedRoseTest {
@Test
void foo() {
Item[] items = new Item[] { new Item("foo", 0, 0) };
void agedBrieIncreasesInQualityByOneEachDay() {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 2, 0) };
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals("fixme", app.items[0].name);
assertEquals(app.items[0].quality, 1);
app.updateQuality();
assertEquals(app.items[0].quality, 2);
}
}

View File

@ -2,8 +2,6 @@ package com.gildedrose;
public class TexttestFixture {
public static void main(String[] args) {
System.out.println("OMGHAI!");
Item[] items = new Item[] {
new Item("+5 Dexterity Vest", 10, 20), //
new Item("Aged Brie", 2, 0), //