OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-10 04:01:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

all tests passed

Browse Source
This commit is contained in:
Clara BG 2025-07-03 17:30:58 +01:00
parent f4e75c8267
commit 82a99bed3a
3 changed files with 19 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
Kotlin/src/main/kotlin/com/gildedrose/GildedRose.kt
View File

@ -2,12 +2,10 @@ package com.gildedrose
class GildedRose(val items: List<Item>) { class GildedRose(val items: List<Item>) {
fun updateQualityClara() { fun updateQuality() {
for (i in items.indices) { for (i in items.indices) {
items[i].sellIn -= 1 if (items[i].name != "Sulfuras, Hand of Ragnaros") {
items[i].sellIn -= 1
if (items[i].name == "Sulfuras, Hand of Ragnaros") { //might not be necessary
items[i].quality = items[i].quality
} }
if (items[i].name == "Aged Brie") { if (items[i].name == "Aged Brie") {
@ -19,7 +17,7 @@ class GildedRose(val items: List<Item>) {
} }
if (items[i].name == "Backstage passes to a TAFKAL80ETC concert" && items[i].sellIn < 0) { if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") {
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
items[i].quality = 0 items[i].quality = 0
} else if (items[i].sellIn in 6..10) { } else if (items[i].sellIn in 6..10) {
@ -41,7 +39,7 @@ class GildedRose(val items: List<Item>) {
} }
if (items[i].name == "Conjured Mana Cake" || items[i].name == "Elixir og the Mongoose") { if (items[i].name == "Conjured Mana Cake") {
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
items[i].quality -= 4 items[i].quality -= 4
@ -51,11 +49,21 @@ class GildedRose(val items: List<Item>) {
} }
if (items[i].name == "Elixir of the Mongoose") {
if (items[i].sellIn < 0) {
items[i].quality -= 2
} else {
items[i].quality -= 1
}
}
if (items[i].quality >= 50 && items[i].name != "Sulfuras, Hand of Ragnaros") { if (items[i].quality >= 50 && items[i].name != "Sulfuras, Hand of Ragnaros") {
items[i].quality = 50 items[i].quality = 50
} }
if (items[i].quality == 0) { if (items[i].quality < 0) {
items[i].quality = 0 items[i].quality = 0
} }
@ -63,59 +71,4 @@ class GildedRose(val items: List<Item>) {
} }
fun updateQuality() {
for (i in items.indices) {
if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") {
if (items[i].quality > 0) {
if (items[i].name != "Sulfuras, Hand of Ragnaros") {
items[i].quality = items[i].quality - 1
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1
if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1
}
}
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1
}
}
}
}
}
if (items[i].name != "Sulfuras, Hand of Ragnaros") {
items[i].sellIn = items[i].sellIn - 1
}
if (items[i].sellIn < 0) {
if (items[i].name != "Aged Brie") {
if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") {
if (items[i].quality > 0) {
if (items[i].name != "Sulfuras, Hand of Ragnaros") {
items[i].quality = items[i].quality - 1
}
}
} else {
items[i].quality = items[i].quality - items[i].quality
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1
}
}
}
}
}
} }

2
Kotlin/src/main/kotlin/com/gildedrose/TexttestFixture.kt
View File

@ -30,6 +30,6 @@ fun main(args: Array<String>) {
println(item) println(item)
} }
println() println()
app.updateQualityClara() app.updateQuality()
} }
} }

4
Kotlin/src/test/kotlin/com/gildedrose/GildedRoseTest.kt
View File

@ -139,7 +139,7 @@ internal class GildedRoseTest {
/*
@Test @Test
fun conjuredBasic() { fun conjuredBasic() {
val items = listOf(Item("Conjured Mana Cake", 3, 6)) val items = listOf(Item("Conjured Mana Cake", 3, 6))
@ -150,7 +150,7 @@ internal class GildedRoseTest {
assertEquals(4, app.items[0].quality) assertEquals(4, app.items[0].quality)
} }
*/
} }