OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-11 04:31:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added support for new Conjured item type

Browse Source
This commit is contained in:
Kunnal-chawla 2025-12-28 10:11:50 +05:30
parent 2947ff0f1b
commit 8862f3150c
2 changed files with 39 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
python/gilded_rose.py
View File

@ -42,6 +42,15 @@ class Updater(object):
item.quality = 0 item.quality = 0
item.sell_in += -1 item.sell_in += -1
def conjured(self, item):
if item.sell_in > 0:
depreciation = -2
else:
depreciation = -4
item.quality = max((item.quality + depreciation), self.MIN_QUALITY)
item.sell_in += -1
class GildedRose(object): class GildedRose(object):
@ -58,6 +67,8 @@ class GildedRose(object):
updater.backstage_passes(item) updater.backstage_passes(item)
elif item.name == 'Sulfuras, Hand of Ragnaros': elif item.name == 'Sulfuras, Hand of Ragnaros':
updater.sulfuras(item) updater.sulfuras(item)
elif item.name == 'Conjured Mana Cake':
updater.conjured(item)
else: else:
updater.normal_item(item) updater.normal_item(item)
@ -70,3 +81,4 @@ class Item:
def __repr__(self): def __repr__(self):
return "%s, %s, %s" % (self.name, self.sell_in, self.quality) return "%s, %s, %s" % (self.name, self.sell_in, self.quality)

28
python/tests/test_gilded_rose.py
View File

@ -4,7 +4,6 @@ from gilded_rose import GildedRose, Item
class GildedRoseTest(unittest.TestCase): class GildedRoseTest(unittest.TestCase):
def updater(obj = GildedRose, times = 1): def updater(obj = GildedRose, times = 1):
for i in range(times): for i in range(times):
obj.update_quality() obj.update_quality()
@ -95,7 +94,8 @@ class GildedRoseTest(unittest.TestCase):
self.assertEqual(item.sell_in, 2) self.assertEqual(item.sell_in, 2)
self.assertEqual(item.quality, 49) self.assertEqual(item.quality, 49)
# Never gets beyond 50 and drops to 0 once sell in passed # Never gets beyond 50 and drops to 0
# once sell in passed
GildedRoseTest.updater(gilded_rose) GildedRoseTest.updater(gilded_rose)
self.assertEqual(item.sell_in, 1) self.assertEqual(item.sell_in, 1)
self.assertEqual(item.quality, 50) self.assertEqual(item.quality, 50)
@ -104,5 +104,29 @@ class GildedRoseTest(unittest.TestCase):
self.assertEqual(item.sell_in, -1) self.assertEqual(item.sell_in, -1)
self.assertEqual(item.quality, 0) self.assertEqual(item.quality, 0)
def test_conjured(self):
# Set up the item
item = Item("Conjured Mana Cake", 20, 50)
gilded_rose = GildedRose([item])
# One day after
gilded_rose.update_quality()
self.assertEqual(item.sell_in, 19)
self.assertEqual(item.quality, 48)
GildedRoseTest.updater(gilded_rose, item.sell_in + 1)
# sell by date passed -- will decrease
# twice as fast as normal items (-4)
self.assertEqual(item.sell_in, -1)
self.assertEqual(item.quality, 6)
GildedRoseTest.updater(gilded_rose)
self.assertEqual(item.sell_in, -2)
self.assertEqual(item.quality, 2)
GildedRoseTest.updater(gilded_rose)
self.assertEqual(item.sell_in, -3)
self.assertEqual(item.quality, 0)
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()