mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-16 06:51:27 +00:00
corrected special_item method and added further test for this.
This commit is contained in:
parent
58be55719a
commit
89fb0d8689
@ -43,6 +43,7 @@ class GildedRose
|
|||||||
|
|
||||||
if !item.name.downcase.match /backstage/
|
if !item.name.downcase.match /backstage/
|
||||||
update_normal_quality(item) unless sulfuras?(item)
|
update_normal_quality(item) unless sulfuras?(item)
|
||||||
|
|
||||||
else
|
else
|
||||||
item.quality = 0
|
item.quality = 0
|
||||||
end
|
end
|
||||||
@ -67,7 +68,7 @@ class GildedRose
|
|||||||
end
|
end
|
||||||
|
|
||||||
def self.special_item?(item)
|
def self.special_item?(item)
|
||||||
!item.name.downcase.match( /Aged Brie/ || /backstage/) || !sulfuras?(item)
|
item.name.downcase.match( /Aged Brie/ || /backstage/).nil? || sulfuras?(item)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
@ -120,7 +120,7 @@ let(:sulfarus) { Item.new('Sulfuras, Hand of Ragnaros', 50, 80) }
|
|||||||
end
|
end
|
||||||
|
|
||||||
it 'returns true for backstage passes' do
|
it 'returns true for backstage passes' do
|
||||||
item_double = double :item, name: "backstage pass for gong party"
|
item_double = double :item, name: "Backstage passes to a TAFKAL80ETC concert"
|
||||||
expect(GildedRose.special_item?(item_double)).to eq true
|
expect(GildedRose.special_item?(item_double)).to eq true
|
||||||
end
|
end
|
||||||
|
|
||||||
@ -128,6 +128,11 @@ let(:sulfarus) { Item.new('Sulfuras, Hand of Ragnaros', 50, 80) }
|
|||||||
sulfuras_double = double :selfarus, name: 'Sulfuras'
|
sulfuras_double = double :selfarus, name: 'Sulfuras'
|
||||||
expect(GildedRose.special_item?(sulfuras_double)).to eq true
|
expect(GildedRose.special_item?(sulfuras_double)).to eq true
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it 'returns false on potato' do
|
||||||
|
item_double = double :item, name: "potato"
|
||||||
|
expect(GildedRose.sulfuras?(item_double)).to eq false
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user