From 8b9bb798180b52988e1c01542d50069c9b761664 Mon Sep 17 00:00:00 2001 From: Dan Holmes Date: Thu, 3 Dec 2020 16:27:19 +0000 Subject: [PATCH] Extract more to bsp module --- js-jasmine/src/backstage_pass_update.js | 14 +++++++++++++- js-jasmine/src/shop.js | 14 +------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/js-jasmine/src/backstage_pass_update.js b/js-jasmine/src/backstage_pass_update.js index c8cf944e..3c11742e 100644 --- a/js-jasmine/src/backstage_pass_update.js +++ b/js-jasmine/src/backstage_pass_update.js @@ -1,5 +1,17 @@ +function getQualityChange(item) { + if (item.sellIn <= 0) { + return -item.quality; + } else if (item.sellIn <= 5) { + return 3; + } else if (item.sellIn <= 10) { + return 2; + } else { + return 1; + } +} + function isBackstagePass(item) { return item.name.toLowerCase().match(/backstage pass/); }; -module.exports = { isBackstagePass } \ No newline at end of file +module.exports = { isBackstagePass, getQualityChange }; \ No newline at end of file diff --git a/js-jasmine/src/shop.js b/js-jasmine/src/shop.js index 8e487cad..02512bc2 100644 --- a/js-jasmine/src/shop.js +++ b/js-jasmine/src/shop.js @@ -26,7 +26,7 @@ class Shop { _getQualityChange(item) { if (bsp.isBackstagePass(item)) { - return this._getQualityChangeBackstagePass(item); + return bsp.getQualityChange(item); } else if (this._isAgedBrie(item)) { return this._getQualityChangeAgedBrie(item); } else if (this._isSulfuras(item)) { @@ -52,18 +52,6 @@ class Shop { } } - _getQualityChangeBackstagePass(item) { - if (item.sellIn <= 0) { - return -item.quality; - } else if (item.sellIn <= 5) { - return 3; - } else if (item.sellIn <= 10) { - return 2; - } else { - return 1; - } - } - _getQualityChangeAgedBrie(item) { if (item.sellIn <= 0) { return 2;