OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Conjured implementation

Browse Source
This commit is contained in:
Joao Esperancinha 2020-01-13 11:45:04 +01:00
parent c8e535cc5c
commit 8bba4fb339
2 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -12,8 +12,16 @@ class GildedRose {
if (!items[i].name.equals("Aged Brie") if (!items[i].name.equals("Aged Brie")
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (items[i].name.equals("Conjured Mana Cake")) {
items[i].quality = items[i].quality - 1; if (items[i].quality > 1) {
items[i].quality -= 2;
} else {
items[i].quality = 0;
}
} else {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
} }
} }
} else { } else {
@ -44,12 +52,20 @@ class GildedRose {
if (!items[i].name.equals("Aged Brie")) { if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (items[i].name.equals("Conjured Mana Cake")) {
items[i].quality = items[i].quality - 1; if (items[i].quality > 1) {
items[i].quality -= 2;
} else {
items[i].quality = 0;
}
} else {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
} }
} }
} else { } else {
items[i].quality = items[i].quality - items[i].quality; items[i].quality = 0;
} }
} else { } else {
if (items[i].quality < 50) { if (items[i].quality < 50) {

4
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -1,6 +1,5 @@
package com.gildedrose; package com.gildedrose;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
@ -95,7 +94,6 @@ class GildedRoseTest {
* Conjured Quality decreases 2 before expired * Conjured Quality decreases 2 before expired
*/ */
@Test @Test
@Disabled
void whenConjuredSale1Quality2_afterUpdate_ThenSale0Quality0() { void whenConjuredSale1Quality2_afterUpdate_ThenSale0Quality0() {
Item[] items = new Item[]{new Item("Conjured Mana Cake", 1, 2)}; Item[] items = new Item[]{new Item("Conjured Mana Cake", 1, 2)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
@ -110,7 +108,6 @@ class GildedRoseTest {
* Conjured Quality decreases 4 after expired * Conjured Quality decreases 4 after expired
*/ */
@Test @Test
@Disabled
void whenConjuredSaleM10Quality8_afterUpdate_ThenSaleM11Quality4() { void whenConjuredSaleM10Quality8_afterUpdate_ThenSaleM11Quality4() {
Item[] items = new Item[]{new Item("Conjured Mana Cake", -10, 8)}; Item[] items = new Item[]{new Item("Conjured Mana Cake", -10, 8)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
@ -125,7 +122,6 @@ class GildedRoseTest {
* Conjured Quality decreases 4 after expired edge * Conjured Quality decreases 4 after expired edge
*/ */
@Test @Test
@Disabled
void whenConjuredSale0Quality10_afterUpdate_ThenSaleM1Quality6() { void whenConjuredSale0Quality10_afterUpdate_ThenSaleM1Quality6() {
Item[] items = new Item[]{new Item("Conjured Mana Cake", 0, 10)}; Item[] items = new Item[]{new Item("Conjured Mana Cake", 0, 10)};
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);