OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove unnecessary conditional logic & use Switch case for clear distinguishability

Browse Source
This commit is contained in:
James Sayer 2022-05-27 09:56:01 -04:00
parent 9f8caa5b64
commit 8e7ca90e9c
1 changed files with 19 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
TypeScript/app/gilded-rose.ts
View File

@ -30,43 +30,30 @@ export class GildedRose {
itemSellin -= 1; itemSellin -= 1;
} }
if (!itemName.includes('Aged Brie') && !itemName.includes('Backstage passes')) { switch (true) {
if (itemQuality > 0) { case itemName.includes('Aged Brie'):
itemQuality = itemQuality - 1 itemQuality = itemQuality + 1;
} break;
} else { case itemName.includes('Backstage passes'):
if (itemQuality < 50) {
itemQuality = itemQuality + 1 itemQuality = itemQuality + 1
if (itemName.includes('Backstage passes')) {
if (itemSellin < 11) { if (itemSellin < 11) {
if (itemQuality < 50) {
itemQuality = itemQuality + 1 itemQuality = itemQuality + 1
} } else if (itemSellin < 6) {
}
if (itemSellin < 6) {
if (itemQuality < 50) {
itemQuality = itemQuality + 1 itemQuality = itemQuality + 1
} } else if (itemSellin < 0) {
}
}
}
}
if (itemSellin < 0) {
if (!itemName.includes('Aged Brie')) {
if (!itemName.includes('Backstage passes')) {
if (itemQuality > 0) {
itemQuality = itemQuality - 1
}
} else {
itemQuality = itemQuality - itemQuality itemQuality = itemQuality - itemQuality
} }
} else { break;
if (itemQuality < 50) { default:
itemQuality = itemQuality + 1 if (itemQuality > 0) {
itemQuality = itemQuality - 1
} }
if (itemSellin < 0) {
itemQuality = itemQuality - itemQuality
} }
break;
} }
this.items[i].quality = itemQuality; this.items[i].quality = itemQuality > 50 ? 50 : itemQuality;
this.items[i].sellIn = itemSellin; this.items[i].sellIn = itemSellin;
} }