From 9482acd29c790759aa5c1de6a49ece23d2d8e4a7 Mon Sep 17 00:00:00 2001 From: doxxx Date: Tue, 10 Oct 2023 15:55:05 +0900 Subject: [PATCH] Refactor arithmetic operations --- .../main/java/com/gildedrose/AgedBrieUpdateStrategy.java | 6 +++--- .../com/gildedrose/BackstagePassesUpdateStrategy.java | 8 ++++---- .../java/com/gildedrose/StandardItemUpdateStrategy.java | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/AgedBrieUpdateStrategy.java b/Java/src/main/java/com/gildedrose/AgedBrieUpdateStrategy.java index fc4d7e61..10b3826a 100644 --- a/Java/src/main/java/com/gildedrose/AgedBrieUpdateStrategy.java +++ b/Java/src/main/java/com/gildedrose/AgedBrieUpdateStrategy.java @@ -4,14 +4,14 @@ public class AgedBrieUpdateStrategy implements ItemUpdateStrategy { @Override public void update(Item item) { if (item.quality < 50) { - item.quality = item.quality + 1; + item.quality += 1; } - item.sellIn = item.sellIn - 1; + item.sellIn -= 1; if (item.sellIn < 0) { if (item.quality < 50) { - item.quality = item.quality + 1; + item.quality += 1; } } } diff --git a/Java/src/main/java/com/gildedrose/BackstagePassesUpdateStrategy.java b/Java/src/main/java/com/gildedrose/BackstagePassesUpdateStrategy.java index 671fa3ac..0c54454b 100644 --- a/Java/src/main/java/com/gildedrose/BackstagePassesUpdateStrategy.java +++ b/Java/src/main/java/com/gildedrose/BackstagePassesUpdateStrategy.java @@ -4,22 +4,22 @@ public class BackstagePassesUpdateStrategy implements ItemUpdateStrategy { @Override public void update(Item item) { if (item.quality < 50) { - item.quality = item.quality + 1; + item.quality += 1; if (item.sellIn < 11) { if (item.quality < 50) { - item.quality = item.quality + 1; + item.quality += 1; } } if (item.sellIn < 6) { if (item.quality < 50) { - item.quality = item.quality + 1; + item.quality += 1; } } } - item.sellIn = item.sellIn - 1; + item.sellIn -= 1; if (item.sellIn < 0) { item.quality = 0; diff --git a/Java/src/main/java/com/gildedrose/StandardItemUpdateStrategy.java b/Java/src/main/java/com/gildedrose/StandardItemUpdateStrategy.java index 50d8224e..85372521 100644 --- a/Java/src/main/java/com/gildedrose/StandardItemUpdateStrategy.java +++ b/Java/src/main/java/com/gildedrose/StandardItemUpdateStrategy.java @@ -5,10 +5,10 @@ public class StandardItemUpdateStrategy implements ItemUpdateStrategy { public void update(Item item) { item.sellIn -= 1; if (item.quality > 0) { - item.quality = item.quality - 1; + item.quality -= 1; } if (item.sellIn < 0 && item.quality > 0) { - item.quality = item.quality - 1; + item.quality -= 1; } } }