OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[重構] 簡化、統一個商品判定邏輯寫法

Browse Source
This commit is contained in:
wengYuting 2022-04-07 22:19:35 +08:00
parent 4e6b0606dd
commit 94cbe129e0
1 changed files with 30 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
js-jest/src/gilded_rose.js
View File

@ -16,7 +16,8 @@ class Shop {
const item = this.items[i]; const item = this.items[i];
if (item.name === "Sulfuras, Hand of Ragnaros") continue; if (item.name === "Sulfuras, Hand of Ragnaros") continue;
item.sellIn = item.sellIn - 1; item.sellIn -= 1;
switch (item.name) { switch (item.name) {
case "Aged Brie": case "Aged Brie":
this.updateAgedBrie(item); this.updateAgedBrie(item);
@ -33,39 +34,42 @@ class Shop {
return this.items; return this.items;
} }
updateAgedBrie(item) { updateAgedBrie(item) {
if (item.quality < 50) { let quality = item.quality;
item.quality = item.quality + 1;
if (item.sellIn < 0) {
item.quality = item.quality + 1;
}
}
}
updateBackstagePasses(item) {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.sellIn < 10 && item.quality < 50) {
item.quality = item.quality + 1;
}
if (item.sellIn < 5 && item.quality < 50) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < 0) { if (item.sellIn < 0) {
item.quality = item.quality - item.quality; quality += 2;
} else {
quality += 1;
} }
item.quality = quality < 50 ? quality : 50;
}
updateBackstagePasses(item) {
let quality = item.quality;
if (item.sellIn < 0) {
quality = 0;
} else if (item.sellIn < 5) {
quality += 3;
} else if (item.sellIn < 10) {
quality += 2;
} else {
quality += 1;
}
item.quality = quality < 50 ? quality : 50;
} }
updateTheOthers(item) { updateTheOthers(item) {
if (item.quality > 0) { let quality = item.quality;
item.quality = item.quality - 1;
if (item.sellIn < 0) { if (item.sellIn < 0) {
item.quality = item.quality - 1; quality -= 2;
} } else {
quality -= 1;
} }
item.quality = quality > 0 ? quality : 0;
} }
} }