OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reduce nested statement and extract methods

Browse Source
This commit is contained in:
kitfbgh 2022-04-02 11:58:02 +08:00
parent 468ff532ea
commit 9572804f09
1 changed files with 25 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
php/src/GildedRose.php
View File

@ -24,53 +24,54 @@ final class GildedRose
public function updateQuality(): void public function updateQuality(): void
{ {
foreach ($this->items as $item) { foreach ($this->items as $item) {
if ($item->name === 'Sulfuras, Hand of Ragnaros') {
continue;
}
if ($item->name === 'Aged Brie' || $item->name === 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name === 'Aged Brie' || $item->name === 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality = $item->quality + 1;
if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->sellIn < 11) { if ($item->sellIn < 11) {
if ($item->quality < 50) { $this->increaseQuality($item);
$item->quality = $item->quality + 1;
}
} }
if ($item->sellIn < 6) { if ($item->sellIn < 6) {
if ($item->quality < 50) { $this->increaseQuality($item);
$item->quality = $item->quality + 1;
}
} }
} }
} }
} else { } else {
if ($item->quality > 0) { $this->decreaseQuality($item);
if ($item->name !== 'Sulfuras, Hand of Ragnaros') {
$item->quality = $item->quality - 1;
}
}
} }
if ($item->name === 'Sulfuras, Hand of Ragnaros') { $item->sellIn = $item->sellIn - 1;
} else {
$item->sellIn = $item->sellIn - 1;
}
if ($item->sellIn < 0) { if ($item->sellIn < 0) {
if ($item->name === 'Aged Brie') { if ($item->name === 'Aged Brie') {
if ($item->quality < 50) { $this->increaseQuality($item);
$item->quality = $item->quality + 1;
}
} else { } else {
if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
$item->quality = $item->quality - $item->quality; $item->quality = $item->quality - $item->quality;
} else { } else {
if ($item->quality > 0) { $this->decreaseQuality($item);
if ($item->name === 'Sulfuras, Hand of Ragnaros') {
} else {
$item->quality = $item->quality - 1;
}
}
} }
} }
} }
} }
} }
private function increaseQuality(Item &$item): void
{
if ($item->quality >= 50) {
return;
}
$item->quality += 1;
}
private function decreaseQuality(Item &$item): void
{
if ($item->quality > 0) {
$item->quality -= 1;
}
}
} }