OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor modules

Browse Source
This commit is contained in:
Dan Holmes 2020-12-04 08:28:57 +00:00
parent 125bb22b38
commit 97a10998ae
5 changed files with 29 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
js-jasmine/src/aged_brie_update.js
View File

@ -1,12 +1,8 @@
const agedBrie = { exports.regex_matcher = /aged brie/;
regex_matcher: /aged brie/, exports.qualityChange = function (sellIn, quality) {
qualityChange: (sellIn) => { if (sellIn <= 0) {
if (sellIn <= 0) { return 2;
return 2; } else {
} else { return 1;
return 1;
}
} }
} };
module.exports = { agedBrie };

24
js-jasmine/src/backstage_pass_update.js
View File

@ -1,16 +1,12 @@
const backstagePass = { exports.regex_matcher = /backstage pass/
regex_matcher: /backstage pass/, exports.qualityChange = function (sellIn, quality) {
qualityChange: (sellIn, quality) => { if (sellIn <= 0) {
if (sellIn <= 0) { return -quality;
return -quality; } else if (sellIn <= 5) {
} else if (sellIn <= 5) { return 3;
return 3; } else if (sellIn <= 10) {
} else if (sellIn <= 10) { return 2;
return 2; } else {
} else { return 1;
return 1;
}
} }
} }
module.exports = { backstagePass };

4
js-jasmine/src/shop.js
View File

@ -3,7 +3,7 @@ const backstagePass = require('./backstage_pass_update.js')
const agedBrie = require('./aged_brie_update.js') const agedBrie = require('./aged_brie_update.js')
const sulfuras = require('./sulfuras_update.js') const sulfuras = require('./sulfuras_update.js')
const itemTypes = [backstagePass.backstagePass, agedBrie.agedBrie, sulfuras.sulfuras] const itemTypes = [backstagePass, agedBrie, sulfuras]
class Shop { class Shop {
constructor(items = []) { constructor(items = []) {
@ -34,7 +34,7 @@ class Shop {
return item.quality += itemType.qualityChange(item.sellIn, item.quality); return item.quality += itemType.qualityChange(item.sellIn, item.quality);
} }
} }
return item.quality += standardItem.standardItem.qualityChange(item.sellIn); return item.quality += standardItem.qualityChange(item.sellIn);
} }
_updateItemSellIn(item) { _updateItemSellIn(item) {

16
js-jasmine/src/standard_update.js
View File

@ -1,11 +1,7 @@
const standardItem = { exports.qualityChange = function (sellIn) {
qualityChange: (sellIn) => { if (sellIn <= 0) {
if (sellIn <= 0) { return -2;
return -2; } else {
} else { return -1;
return -1;
}
} }
} }
module.exports = { standardItem };

12
js-jasmine/src/sulfuras_update.js
View File

@ -1,8 +1,4 @@
const sulfuras = { exports.regex_matcher = /sulfuras/;
regex_matcher: /sulfuras/, exports.qualityChange = function () {
qualityChange: () => { return 0;
return 0; };
}
}
module.exports = { sulfuras };