OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

把每個item的運算都抽成function

Browse Source
This commit is contained in:
liaolizhen 2020-08-13 17:50:04 +08:00
parent 31f7d222ea
commit 98ff07fb44
1 changed files with 38 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -18,14 +18,19 @@ class GildedRose {
return; return;
} }
if (item.name.equals("Aged Brie")) {
updateAgedBrie(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
updateBackstagePasses(item);
} else {
updateNormal(item);
}
}
private void updateBackstagePasses(Item item) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
if (item.name.equals("Aged Brie")) {
increaseQuality(item);
if (item.sellIn < 0) {
increaseQuality(item);
}
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
increaseQuality(item); increaseQuality(item);
if (item.sellIn < 10) { if (item.sellIn < 10) {
@ -39,13 +44,24 @@ class GildedRose {
if (item.sellIn < 0) { if (item.sellIn < 0) {
item.quality = item.quality - item.quality; item.quality = item.quality - item.quality;
} }
}
private void updateNormal(Item item) {
item.sellIn = item.sellIn - 1;
} else {
decreaseQuality(item); decreaseQuality(item);
if (item.sellIn < 0) { if (item.sellIn < 0) {
decreaseQuality(item); decreaseQuality(item);
} }
} }
private void updateAgedBrie(Item item) {
item.sellIn = item.sellIn - 1;
increaseQuality(item);
if (item.sellIn < 0) {
increaseQuality(item);
}
} }
public void decreaseQuality(Item item) { public void decreaseQuality(Item item) {