From 99de845aa5441ebf21dddf21a0b5148fb74973e9 Mon Sep 17 00:00:00 2001 From: EmanFateen Date: Sat, 22 Nov 2025 23:18:24 +0200 Subject: [PATCH] chore: remove duplicate code --- php/src/GildedRose.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/php/src/GildedRose.php b/php/src/GildedRose.php index 395c02b8..e816b8d4 100644 --- a/php/src/GildedRose.php +++ b/php/src/GildedRose.php @@ -24,7 +24,6 @@ final class GildedRose if ($item->name === 'Aged Brie') { $item->quality = min(50, ++$item->quality); - } else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { if ($item->sellIn < 6) { $updatedQuality = $item->quality + 3; @@ -34,18 +33,15 @@ final class GildedRose $item->quality = min(50, $updatedQuality); } } else { - $item->quality = max(0, --$item->quality); + $updatedQuality = $item->quality - 2; + $item->quality = max(0, $updatedQuality); } $item->sellIn--; if ($item->sellIn < 0) { - if ($item->name === 'Aged Brie') { - $item->quality = min(50, ++$item->quality); - } else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') + if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') $item->quality = 0; - else - $item->quality = max(0, --$item->quality); } } }