OpenSource/GildedRose-Refactoring-Kata
1
0 Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-10-15 02:25:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactoring c# projects (#544)

Browse Source 
Small Refactoring c# projects, e.g.
* add days
* remove StartupObject
* Fix Approval tests for NUnit
* Use Environment.NewLine in Xunit tests
* Added + fixed README.md
* Removed global.json
This commit is contained in:
Stef Heyenrath authored and GitHub committed 2024-06-06 14:13:44 +02:00
1 parent a348b20789
commit 99f2fcbf18
17 files changed
+263 -236
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

csharp.NUnit/GildedRoseTests/ApprovalTest.cs
+6 -2
View File
@@ -1,10 +1,14 @@
using GildedRoseKata;
using System;
using System.IO;
using System.Text;
using System.Threading.Tasks;
using NUnit.Framework;
using VerifyNUnit;
using NUnit.Framework;
namespace GildedRoseTests;
public class ApprovalTest
@@ -16,7 +20,7 @@ public class ApprovalTest
Console.SetOut(new StringWriter(fakeOutput));
Console.SetIn(new StringReader($"a{Environment.NewLine}"));
TextTestFixture.Main(new string[] { "30" });
Program.Main(new string[] { "30" });
var output = fakeOutput.ToString();
return Verifier.Verify(output);
csharp.NUnit/GildedRoseTests/GildedRoseTests.csproj
+17 -18
View File
@@ -1,24 +1,23 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<StartupObject>GildedRoseTests.TextTestFixture</StartupObject>
</PropertyGroup>
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Verify.NUnit" Version="23.1.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="NUnit" Version="4.0.1" />
<PackageReference Include="coverlet.collector" Version="6.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Verify.NUnit" Version="23.1.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="NUnit" Version="4.0.1" />
<PackageReference Include="coverlet.collector" Version="6.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\GildedRose\GildedRose.csproj" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\GildedRose\GildedRose.csproj" />
</ItemGroup>
</Project>
csharp.NUnit/GildedRoseTests/TextTestFixture.cs
-61
View File
@@ -1,61 +0,0 @@
using System;
using System.Collections.Generic;
using GildedRoseKata;
namespace GildedRoseTests;
public static class TextTestFixture
{
public static void Main(string[] args)
{
Console.WriteLine("OMGHAI!");
var items = new List<Item>{
new Item {Name = "+5 Dexterity Vest", SellIn = 10, Quality = 20},
new Item {Name = "Aged Brie", SellIn = 2, Quality = 0},
new Item {Name = "Elixir of the Mongoose", SellIn = 5, Quality = 7},
new Item {Name = "Sulfuras, Hand of Ragnaros", SellIn = 0, Quality = 80},
new Item {Name = "Sulfuras, Hand of Ragnaros", SellIn = -1, Quality = 80},
new Item
{
Name = "Backstage passes to a TAFKAL80ETC concert",
SellIn = 15,
Quality = 20
},
new Item
{
Name = "Backstage passes to a TAFKAL80ETC concert",
SellIn = 10,
Quality = 49
},
new Item
{
Name = "Backstage passes to a TAFKAL80ETC concert",
SellIn = 5,
Quality = 49
},
// this conjured item does not work properly yet
new Item {Name = "Conjured Mana Cake", SellIn = 3, Quality = 6}
};
var app = new GildedRose(items);
int days = 2;
if (args.Length > 0)
{
days = int.Parse(args[0]) + 1;
}
for (var i = 0; i < days; i++)
{
Console.WriteLine("-------- day " + i + " --------");
Console.WriteLine("name, sellIn, quality");
for (var j = 0; j < items.Count; j++)
{
Console.WriteLine(items[j].Name + ", " + items[j].SellIn + ", " + items[j].Quality);
}
Console.WriteLine("");
app.UpdateQuality();
}
}
}