OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2025-12-12 04:12:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use foreach for extra indentation

Browse Source
This commit is contained in:
Nitsan Avni 2023-02-07 08:35:39 +00:00
parent 9abe955027
commit 9a2736d267
3 changed files with 47 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
jq/gilded-rose.jq
View File

@ -1,49 +1,54 @@
def update_quality: def update_quality:
if .name != "Aged Brie" and .name != "Backstage passes to a TAFKAL80ETC concert" then [
if .quality > 0 then foreach .[] as $item (
if .name != "Sulfuras, Hand of Ragnaros" then null;
.quality = .quality - 1 $item |
else . end if .name != "Aged Brie" and .name != "Backstage passes to a TAFKAL80ETC concert" then
else . end
else
if .quality < 50 then
.quality = .quality + 1
|
if .name == "Backstage passes to a TAFKAL80ETC concert" then
if .sell_in < 11 then
if .quality < 50 then
.quality = .quality + 1
else . end
else . end
|
if .sell_in < 6 then
if .quality < 50 then
.quality = .quality + 1
else . end
else . end
else . end
else . end
end
|
if .name != "Sulfuras, Hand of Ragnaros" then
.sell_in = .sell_in - 1
else . end
|
if .sell_in < 0 then
if .name != "Aged Brie" then
if .name != "Backstage passes to a TAFKAL80ETC concert" then
if .quality > 0 then if .quality > 0 then
if .name != "Sulfuras, Hand of Ragnaros" then if .name != "Sulfuras, Hand of Ragnaros" then
.quality = .quality - 1 .quality = .quality - 1
else . end else . end
else . end else . end
else else
.quality = .quality - .quality if .quality < 50 then
.quality = .quality + 1
|
if .name == "Backstage passes to a TAFKAL80ETC concert" then
if .sell_in < 11 then
if .quality < 50 then
.quality = .quality + 1
else . end
else . end
|
if .sell_in < 6 then
if .quality < 50 then
.quality = .quality + 1
else . end
else . end
else . end
else . end
end end
else |
if .quality < 50 then if .name != "Sulfuras, Hand of Ragnaros" then
.quality = .quality + 1 .sell_in = .sell_in - 1
else . end else . end
end |
else . end if .sell_in < 0 then
; if .name != "Aged Brie" then
if .name != "Backstage passes to a TAFKAL80ETC concert" then
if .quality > 0 then
if .name != "Sulfuras, Hand of Ragnaros" then
.quality = .quality - 1
else . end
else . end
else
.quality = .quality - .quality
end
else
if .quality < 50 then
.quality = .quality + 1
else . end
end
else . end
)
];

2
jq/test-gilded-rose.sh
View File

@ -1,3 +1,3 @@
#!/usr/bin/env bash #!/usr/bin/env bash
jaq -en "$(cat gilded-rose.jq)"'{name:"foo",sell_in:0,quality:0} | update_quality | .name == "fixme"' jaq -en "$(cat gilded-rose.jq)"'[{name:"foo",sell_in:0,quality:0}] | update_quality | .[].name == "fixme"'

2
jq/texttest_fixture.jq
View File

@ -12,7 +12,7 @@
{ name: "Conjured Mana Cake", sell_in: 3, quality: 6} # <-- :O { name: "Conjured Mana Cake", sell_in: 3, quality: 6} # <-- :O
] | ] |
{ items: ., day: 0 } | { items: ., day: 0 } |
recurse(.day += 1 | .items = [.items[] | update_quality]; .day < ($ARGS.named.days // 2 | tonumber)) | recurse(.day += 1 | .items = (.items | update_quality); .day < ($ARGS.named.days // 2 | tonumber)) |
( (
"", "",
(["-------- day ", (.day | tostring), " --------"] | add), (["-------- day ", (.day | tostring), " --------"] | add),