From 9f2e89713f579ea14af3704edb98c1da0f32b413 Mon Sep 17 00:00:00 2001 From: "jiajun.chou" Date: Thu, 13 Aug 2020 21:28:45 +0800 Subject: [PATCH] [Duplicated Code] extract to function --- .../main/java/com/gildedrose/GildedRose.java | 26 +++++++++---------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 81353091..fee942b3 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -28,13 +28,7 @@ class GildedRose { } } } else { - if (items[i].quality > 0) { - if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - - } else { - items[i].quality = items[i].quality - 1; - } - } + caculateQuilaty_without_Sulfuras(i); } if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { @@ -52,16 +46,20 @@ class GildedRose { if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { items[i].quality = items[i].quality - items[i].quality; } else { - if (items[i].quality > 0) { - if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - - } else { - items[i].quality = items[i].quality - 1; - } - } + caculateQuilaty_without_Sulfuras(i); } } } } } + + private void caculateQuilaty_without_Sulfuras(int i) { + if (items[i].quality > 0) { + if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { + + } else { + items[i].quality = items[i].quality - 1; + } + } + } }