OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-19 08:21:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Flatten conditionals

Browse Source
This commit is contained in:
Jesper 2022-04-13 16:57:38 +02:00
parent b0c4797e66
commit a06e221197
1 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
TypeScript/app/gilded-rose.ts
View File

@ -19,23 +19,17 @@ export class GildedRose {
updateQuality() { updateQuality() {
this.items.forEach((item, i) => { this.items.forEach((item, i) => {
if (item.name == 'Aged Brie' || item.name == 'Backstage passes to a TAFKAL80ETC concert') { if (item.name === 'Sulfuras, Hand of Ragnaros') {
if (item.name == 'Aged Brie') { // Do Nothing
} else if (item.name == 'Aged Brie') {
this.incrementQuality(item); this.incrementQuality(item);
} } else if (item.name == 'Backstage passes to a TAFKAL80ETC concert') {
if (item.name == 'Backstage passes to a TAFKAL80ETC concert') {
this.incrementQuality(item); this.incrementQuality(item);
if (item.sellIn < 11) this.incrementQuality(item) if (item.sellIn < 11) this.incrementQuality(item)
if (item.sellIn < 6) this.incrementQuality(item) if (item.sellIn < 6) this.incrementQuality(item)
} } else if (item.quality > 0) {
} else {
if (item.quality > 0) {
if (item.name != 'Sulfuras, Hand of Ragnaros') {
item.quality = item.quality - 1 item.quality = item.quality - 1
} }
}
}
if (item.name != 'Sulfuras, Hand of Ragnaros') { if (item.name != 'Sulfuras, Hand of Ragnaros') {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} }