OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 15:31:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor to use List

Browse Source
This commit is contained in:
Richard Xu 2022-12-22 12:00:07 -05:00
parent a32716843e
commit a1cbfa17e2
2 changed files with 84 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,65 +1,69 @@
package com.gildedrose; package com.gildedrose;
import java.util.Arrays;
import java.util.List;
class GildedRose { class GildedRose {
public static final String AGED_BRIE = "Aged Brie"; public static final String AGED_BRIE = "Aged Brie";
public static final String SULFURAS = "Sulfuras, Hand of Ragnaros"; public static final String SULFURAS = "Sulfuras, Hand of Ragnaros";
public static final String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert"; public static final String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert";
final List<Item> items;
Item[] items;
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
this.items = items; this.items = Arrays.asList(items);
} }
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { items.forEach(GildedRose::handleDay);
if (!items[i].name.equals(AGED_BRIE) }
&& !items[i].name.equals(BACKSTAGE_PASSES)) {
if (items[i].quality > 0) { private static void handleDay(Item item) {
if (!items[i].name.equals(SULFURAS)) { if (!item.name.equals(AGED_BRIE)
items[i].quality = items[i].quality - 1; && !item.name.equals(BACKSTAGE_PASSES)) {
} if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
} }
} else { }
if (items[i].quality < 50) { } else {
items[i].quality = items[i].quality + 1; if (item.quality < 50) {
item.quality = item.quality + 1;
if (items[i].name.equals(BACKSTAGE_PASSES)) { if (item.name.equals(BACKSTAGE_PASSES)) {
if (items[i].sellIn < 11) { if (item.sellIn < 11) {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
}
} }
}
if (items[i].sellIn < 6) { if (item.sellIn < 6) {
if (items[i].quality < 50) { if (item.quality < 50) {
items[i].quality = items[i].quality + 1; item.quality = item.quality + 1;
}
} }
} }
} }
} }
}
if (!items[i].name.equals(SULFURAS)) { if (!item.name.equals(SULFURAS)) {
items[i].sellIn = items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (items[i].sellIn < 0) { if (item.sellIn < 0) {
if (!items[i].name.equals(AGED_BRIE)) { if (!item.name.equals(AGED_BRIE)) {
if (!items[i].name.equals(BACKSTAGE_PASSES)) { if (!item.name.equals(BACKSTAGE_PASSES)) {
if (items[i].quality > 0) { if (item.quality > 0) {
if (!items[i].name.equals(SULFURAS)) { if (!item.name.equals(SULFURAS)) {
items[i].quality = items[i].quality - 1; item.quality = item.quality - 1;
}
} }
} else {
items[i].quality = items[i].quality - items[i].quality;
} }
} else { } else {
if (items[i].quality < 50) { item.quality = item.quality - item.quality;
items[i].quality = items[i].quality + 1; }
} } else {
if (item.quality < 50) {
item.quality = item.quality + 1;
} }
} }
} }

84
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -11,9 +11,9 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 2, 0) }; Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 2, 0) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 1); assertEquals(app.items.get(0).quality, 1);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 2); assertEquals(app.items.get(0).quality, 2);
} }
@Test @Test
@ -22,9 +22,9 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, sellIn, SULFURAS_QUALITY) }; Item[] items = new Item[] { new Item(GildedRose.SULFURAS, sellIn, SULFURAS_QUALITY) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, sellIn); assertEquals(app.items.get(0).sellIn, sellIn);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, sellIn); assertEquals(app.items.get(0).sellIn, sellIn);
} }
@Test @Test
@ -32,9 +32,9 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) }; Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, SULFURAS_QUALITY); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, SULFURAS_QUALITY); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
} }
@Test @Test
@ -42,7 +42,7 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) }; Item[] items = new Item[] { new Item(GildedRose.SULFURAS, 10, SULFURAS_QUALITY) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, SULFURAS_QUALITY); assertEquals(app.items.get(0).quality, SULFURAS_QUALITY);
} }
@Test @Test
@ -51,9 +51,9 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 10, quality) }; Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 10, quality) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 2); assertEquals(app.items.get(0).quality, 2);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 4); assertEquals(app.items.get(0).quality, 4);
} }
@Test @Test
@ -62,11 +62,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, quality) }; Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, quality) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 3); assertEquals(app.items.get(0).quality, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 6); assertEquals(app.items.get(0).quality, 6);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 9); assertEquals(app.items.get(0).quality, 9);
} }
@Test @Test
@ -75,9 +75,9 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 1, quality) }; Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 1, quality) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 13); assertEquals(app.items.get(0).quality, 13);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 0); assertEquals(app.items.get(0).quality, 0);
} }
@Test @Test
@ -87,11 +87,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item("generic item", 5, quality) }; Item[] items = new Item[] { new Item("generic item", 5, quality) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 0); assertEquals(app.items.get(0).quality, 0);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 0); assertEquals(app.items.get(0).quality, 0);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 0); assertEquals(app.items.get(0).quality, 0);
} }
@Test @Test
@ -99,11 +99,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 50) }; Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 50) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 50); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 50); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 50); assertEquals(app.items.get(0).quality, 50);
} }
@Test @Test
@ -111,11 +111,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 50) }; Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 50) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 50); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 50); assertEquals(app.items.get(0).quality, 50);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 50); assertEquals(app.items.get(0).quality, 50);
} }
@Test @Test
@ -123,11 +123,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item("generic item", 5, 5) }; Item[] items = new Item[] { new Item("generic item", 5, 5) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 4); assertEquals(app.items.get(0).quality, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 3); assertEquals(app.items.get(0).quality, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 2); assertEquals(app.items.get(0).quality, 2);
} }
@Test @Test
@ -135,11 +135,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item("generic item", 1, 6) }; Item[] items = new Item[] { new Item("generic item", 1, 6) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 5); assertEquals(app.items.get(0).quality, 5);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 3); assertEquals(app.items.get(0).quality, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].quality, 1); assertEquals(app.items.get(0).quality, 1);
} }
@Test @Test
@ -147,11 +147,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 1) }; Item[] items = new Item[] { new Item(GildedRose.AGED_BRIE, 5, 1) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 3); assertEquals(app.items.get(0).sellIn, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 2); assertEquals(app.items.get(0).sellIn, 2);
} }
@Test @Test
@ -159,11 +159,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 1) }; Item[] items = new Item[] { new Item(GildedRose.BACKSTAGE_PASSES, 5, 1) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 3); assertEquals(app.items.get(0).sellIn, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 2); assertEquals(app.items.get(0).sellIn, 2);
} }
@Test @Test
@ -171,11 +171,11 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item("generic item", 5, 1) }; Item[] items = new Item[] { new Item("generic item", 5, 1) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 4); assertEquals(app.items.get(0).sellIn, 4);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 3); assertEquals(app.items.get(0).sellIn, 3);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 2); assertEquals(app.items.get(0).sellIn, 2);
} }
@Test @Test
@ -183,10 +183,12 @@ class GildedRoseTest {
Item[] items = new Item[] { new Item("generic item", 1, 1) }; Item[] items = new Item[] { new Item("generic item", 1, 1) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, 0); assertEquals(app.items.get(0).sellIn, 0);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, -1); assertEquals(app.items.get(0).sellIn, -1);
app.updateQuality(); app.updateQuality();
assertEquals(app.items[0].sellIn, -2); assertEquals(app.items.get(0).sellIn, -2);
} }
// todo: add test that multiple items update at once (so can pass in multiple items)
} }