Add eslint and apply fixes

js-jasmine/.eslintrc.json

@@ -0,0 +1,17 @@
+{
+  "env": {
+    "browser": true,
+    "commonjs": true,
+    "es2021": true
+  },
+  "extends": "eslint:recommended",
+  "parserOptions": {
+    "ecmaVersion": 12
+  },
+  "rules": {
+    "semi": [
+      "error",
+      "always"
+    ]
+  }
+}

js-jasmine/README.md

@@ -19,3 +19,4 @@ The test spec required that I did not alter the Item class. This made it more di
 
 My tests verged on state driven rather than behaviour driven. I could not find an equivalent of RSpec's "change by" matcher for Jasmine. Any tips would be appreciated.
 
+With more time I would add a 'sellInChange' function to each item type to mirror the qualityChange. The different sellIn change for Sulfurus is still handled by exception.

js-jasmine/package.json

@@ -24,6 +24,7 @@
     "babel-core": "^6.26.0",
     "babel-preset-env": "1.7.0",
     "babel-register": "^6.26.0",
+    "eslint": "^7.14.0",
     "glob": "^7.1.6",
     "jasmine": "^3.2.0",
     "path": "^0.12.7"

js-jasmine/src/item.js

@@ -5,3 +5,6 @@ class Item {
     this.quality = quality;
   }
 }
+module.exports = {
+  Item
+};

js-jasmine/src/item_types/aged_brie_update.js

@@ -1,5 +1,5 @@
 exports.regex_matcher = /aged brie/;
-exports.qualityChange = function (sellIn, quality) {
+exports.qualityChange = function (sellIn) {
   if (sellIn <= 0) {
     return 2;
   } else {

js-jasmine/src/item_types/conjured_update.js

@@ -1,5 +1,5 @@
 exports.regex_matcher = /conjured/;
-exports.qualityChange = function (sellIn, quality) {
+exports.qualityChange = function (sellIn) {
   if (sellIn <= 0) {
     return -4;
   } else {

js-jasmine/src/shop.js

@@ -7,7 +7,7 @@ glob.sync('./src/item_types/**/*.js').forEach(function (file) {
   itemTypes.push(require(path.resolve(file)));
 });
 
-const standardItem = require('./standard_update.js')
+const standardItem = require('./standard_update.js');
 class Shop {
   constructor(items = []) {
     this.items = items;
@@ -17,7 +17,7 @@ class Shop {
   updateQuality() {
     this.items.forEach(item =>
       this._updateItem(item)
-    )
+    );
     return this.items;
   }
 
@@ -27,8 +27,8 @@ class Shop {
   }
 
   _updateItemQuality(item) {
-    this._conditionallyUpdateQuality(item)
+    this._conditionallyUpdateQuality(item);
-    this._checkQualityBounds(item)
+    this._checkQualityBounds(item);
   }
 
   _conditionallyUpdateQuality(item) {
@@ -65,4 +65,4 @@ class Shop {
 }
 module.exports = {
   Shop
-}
+};