OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-14 22:21:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor updatequality method

Browse Source 
Remove repetitive if paths
This commit is contained in:
romerojhonatan20 2018-01-22 21:07:47 -07:00 committed by GitHub
parent 6f972d0c5f
commit a50a0cba65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 37 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -7,56 +7,52 @@ class GildedRose {
this.items = items;
}
public void updateQuality() {
{
for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie")
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
Item item = items[i];
if (item.name.equals("Sulfuras, Hand of Ragnaros"))continue;
if (item.name.equals("Aged Brie") || item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality < 50) {
item.quality += 1;
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality += 1;
}
}
if (item.sellIn < 6) {
if (item.quality < 50) {
item.quality += 1;
}
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
if (item.quality > 0) {
item.quality -= 1;
}
}
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1;
item.sellIn -= 1;
if (item.sellIn > 0) continue;
if (!item.name.equals("Aged Brie") || !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality < 0) continue;
item.quality += 1;
continue;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
if (item.name.equals("Aged Brie")) {
if (item.quality > 50) continue;
item.quality += 1;
} else {
item.quality = 0;
}
}
}
}
}