OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove now unneccasary methods

Browse Source
This commit is contained in:
Dan Holmes 2020-12-03 17:04:48 +00:00
parent 1a8c9a073f
commit a7b54f052b
1 changed files with 10 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
js-jasmine/src/shop.js
View File

@ -18,44 +18,32 @@ class Shop {
_updateItem(item) { _updateItem(item) {
this._updateItemQuality(item); this._updateItemQuality(item);
this._checkMaxQuality(item);
this._checkMinQuality(item);
this._updateItemSellIn(item); this._updateItemSellIn(item);
} }
_updateItemQuality(item) { _updateItemQuality(item) {
this._conditionallyUpdateQuality(item)
this._checkQualityBounds(item)
}
_conditionallyUpdateQuality(item) {
standardItem.updateQuality(item); standardItem.updateQuality(item);
backstagePass.updateQuality(item); backstagePass.updateQuality(item);
agedBrie.updateQuality(item); agedBrie.updateQuality(item);
sulfuras.updateQuality(item); sulfuras.updateQuality(item);
} }
_getQualityChange(item) {
if (backstagePass.is(item)) {
return 0;
} else if (aged_brie.is(item)) {
return aged_brie.getQualityChange(item);
} else if (sulfuras.is(item)) {
return sulfuras.getQualityChange(item);
} else {
return this._getQualityChangeStandard(item);
}
}
_getQualityChangeStandard(item) {
if (item.sellIn <= 0) {
return -2;
} else {
return -1;
}
}
_updateItemSellIn(item) { _updateItemSellIn(item) {
if (item.name != 'Sulfuras, Hand of Ragnaros') { if (item.name != 'Sulfuras, Hand of Ragnaros') {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} }
} }
_checkQualityBounds(item) {
this._checkMaxQuality(item);
this._checkMinQuality(item);
}
_checkMaxQuality(item) { _checkMaxQuality(item) {
if (item.quality > this.MAX_QUALITY) { if (item.quality > this.MAX_QUALITY) {
item.quality = this.MAX_QUALITY; item.quality = this.MAX_QUALITY;