OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 15:31:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[重構] 判斷若為 Sulfuras 則不作為跳至下一輪迴圈，簡化相關判定

Browse Source
This commit is contained in:
wengYuting 2022-04-07 17:07:00 +08:00
parent bfb20fbad4
commit a95501bfb0
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js-jest/src/gilded_rose.js
View File

@ -20,6 +20,8 @@ class Shop {
updateQuality() { updateQuality() {
for (let i = 0; i < this.items.length; i++) { for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name === "Sulfuras, Hand of Ragnaros") continue;
if ( if (
this.items[i].name === "Aged Brie" || this.items[i].name === "Aged Brie" ||
this.items[i].name === "Backstage passes to a TAFKAL80ETC concert" this.items[i].name === "Backstage passes to a TAFKAL80ETC concert"
@ -37,26 +39,18 @@ class Shop {
} }
} }
} }
} else if ( } else if (this.items[i].quality > 0) {
this.items[i].quality > 0 &&
this.items[i].name != "Sulfuras, Hand of Ragnaros"
) {
this.items[i].quality = this.items[i].quality - 1; this.items[i].quality = this.items[i].quality - 1;
} }
if (this.items[i].name != "Sulfuras, Hand of Ragnaros") { this.items[i].sellIn = this.items[i].sellIn - 1;
this.items[i].sellIn = this.items[i].sellIn - 1;
}
if (this.items[i].sellIn < 0) { if (this.items[i].sellIn < 0) {
if (this.items[i].name != "Aged Brie") { if (this.items[i].name != "Aged Brie") {
if ( if (
this.items[i].name != "Backstage passes to a TAFKAL80ETC concert" this.items[i].name != "Backstage passes to a TAFKAL80ETC concert"
) { ) {
if ( if (this.items[i].quality > 0) {
this.items[i].quality > 0 &&
this.items[i].name != "Sulfuras, Hand of Ragnaros"
) {
this.items[i].quality = this.items[i].quality - 1; this.items[i].quality = this.items[i].quality - 1;
} }
} else { } else {