OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace loop with .forEach

Browse Source
This commit is contained in:
Jesper 2022-04-13 16:25:18 +02:00
parent 181b48aff7
commit ab6be24de4
2 changed files with 105 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
TypeScript/app/gilded-rose.ts
View File

@ -18,51 +18,51 @@ export class GildedRose {
} }
updateQuality() { updateQuality() {
for (let i = 0; i < this.items.length; i++) { this.items.forEach((item, i) => {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (item.name != 'Aged Brie' && item.name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) { if (item.quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (item.name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1 item.quality = item.quality - 1
} }
} }
} else { } else {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1 item.quality = item.quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') { if (item.name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) { if (item.sellIn < 11) {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1 item.quality = item.quality + 1
} }
} }
if (this.items[i].sellIn < 6) { if (item.sellIn < 6) {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1 item.quality = item.quality + 1
} }
} }
} }
} }
} }
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (item.name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (this.items[i].sellIn < 0) { if (item.sellIn < 0) {
if (this.items[i].name != 'Aged Brie') { if (item.name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (item.name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) { if (item.quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { if (item.name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1 item.quality = item.quality - 1
} }
} }
} else { } else {
this.items[i].quality = this.items[i].quality - this.items[i].quality item.quality = item.quality - item.quality
} }
} else { } else {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1 item.quality = item.quality + 1
} }
} }
} }
} })
return this.items; return this.items;
} }

87
TypeScript/test/jest/gilded-rose.spec.ts
View File

@ -1,9 +1,80 @@
import { Item, GildedRose } from '@/gilded-rose'; import { Item, GildedRose } from '@/gilded-rose'
describe('Gilded Rose', () => { /**
it('should foo', () => { * A copy of the unrefactored GildedRose class which will be used for acceptance tests
const gildedRose = new GildedRose([new Item('foo', 0, 0)]); */
const items = gildedRose.updateQuality(); export class AcceptanceGildedRose {
expect(items[0].name).toBe('fixme'); items: Array<Item>;
});
}); constructor(items = [] as Array<Item>) {
this.items = items;
}
updateQuality() {
for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
}
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1;
}
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
}
return this.items;
}
}
test('acceptance tests', () => {
const names = ['Aged Brie', 'Backstage passes to a TAFKAL80ETC concert', 'Sulfuras, Hand of Ragnaros']
const sellIns = [-1, 0, 1, 2, 5, 6, 7, 10, 11, 12, 13, 14, 15]
const qualities = [-1, 1, 2, 48, 49, 50, 51]
for (const name of names) {
for (const sellIn of sellIns) {
for (const quality of qualities) {
const gildedRose = new GildedRose([new Item(name, sellIn, quality)])
const acceptanceGildedRose = new AcceptanceGildedRose([new Item(name, sellIn, quality)])
expect(gildedRose.updateQuality()).toEqual(acceptanceGildedRose.updateQuality())
expect(gildedRose.items).toEqual(acceptanceGildedRose.items)
}
}
}
})