OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-14 06:01:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: remove unneeded if condition

Browse Source
This commit is contained in:
EmanFateen 2025-11-22 23:16:56 +02:00
parent a15f346abb
commit ad56ab6239
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
php/src/GildedRose.php
View File

@ -22,9 +22,7 @@ final class GildedRose
continue; continue;
} }
if ($item->name != 'Aged Brie' and $item->name != 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name === 'Aged Brie') {
$item->quality = max(0, --$item->quality);
} else if ($item->name === 'Aged Brie') {
$item->quality = min(50, ++$item->quality); $item->quality = min(50, ++$item->quality);
} else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { } else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
@ -36,12 +34,9 @@ final class GildedRose
$item->quality = min(50, $updatedQuality); $item->quality = min(50, $updatedQuality);
} }
} else { } else {
if ($item->quality < 50) { $item->quality = max(0, --$item->quality);
$item->quality = $item->quality + 1;
}
} }
$item->sellIn--; $item->sellIn--;
if ($item->sellIn < 0) { if ($item->sellIn < 0) {