mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-10 20:21:26 +00:00
Added abstraction class to make sure base classes implement the necessary function
This commit is contained in:
parent
9dcbde01e8
commit
ae01635c99
@ -1,21 +1,25 @@
|
|||||||
|
from abc import ABC, abstractmethod
|
||||||
|
|
||||||
from python.helper import decrease_quality, increase_quality
|
from python.helper import decrease_quality, increase_quality
|
||||||
|
|
||||||
|
|
||||||
class Item:
|
class Item(ABC):
|
||||||
def __init__(self, name, sell_in, quality):
|
|
||||||
self.name = name
|
|
||||||
self.sell_in = sell_in
|
|
||||||
self.quality = quality
|
|
||||||
|
|
||||||
|
@abstractmethod
|
||||||
|
def __init__(self):
|
||||||
|
pass
|
||||||
|
|
||||||
|
@abstractmethod
|
||||||
def update_quality(self):
|
def update_quality(self):
|
||||||
"""Update the quality of an item"""
|
"""Update the quality of an item"""
|
||||||
pass
|
pass
|
||||||
|
|
||||||
def __repr__(self):
|
|
||||||
return "%s, %s, %s" % (self.name, self.sell_in, self.quality)
|
|
||||||
|
|
||||||
|
|
||||||
class RegularItem(Item):
|
class RegularItem(Item):
|
||||||
|
def __init__(self, name, sell_in, quality):
|
||||||
|
self.name = name
|
||||||
|
self.sell_in = sell_in
|
||||||
|
self.quality = quality
|
||||||
|
|
||||||
def update_quality(self):
|
def update_quality(self):
|
||||||
"""Update the quality of an item"""
|
"""Update the quality of an item"""
|
||||||
@ -24,12 +28,20 @@ class RegularItem(Item):
|
|||||||
|
|
||||||
|
|
||||||
class Sulfuras(Item):
|
class Sulfuras(Item):
|
||||||
|
def __init__(self, name, sell_in, quality):
|
||||||
|
self.name = name
|
||||||
|
self.sell_in = sell_in
|
||||||
|
self.quality = quality
|
||||||
|
|
||||||
def update_quality(self):
|
def update_quality(self):
|
||||||
pass
|
pass
|
||||||
|
|
||||||
|
|
||||||
class Backstage(Item):
|
class Backstage(Item):
|
||||||
|
def __init__(self, name, sell_in, quality):
|
||||||
|
self.name = name
|
||||||
|
self.sell_in = sell_in
|
||||||
|
self.quality = quality
|
||||||
|
|
||||||
def update_quality(self):
|
def update_quality(self):
|
||||||
if self.sell_in <= 0:
|
if self.sell_in <= 0:
|
||||||
@ -40,11 +52,14 @@ class Backstage(Item):
|
|||||||
self.quality = increase_quality(quality=self.quality, increase_quality_by=2)
|
self.quality = increase_quality(quality=self.quality, increase_quality_by=2)
|
||||||
else:
|
else:
|
||||||
self.quality = increase_quality(quality=self.quality)
|
self.quality = increase_quality(quality=self.quality)
|
||||||
|
|
||||||
self.sell_in = self.sell_in - 1
|
self.sell_in = self.sell_in - 1
|
||||||
|
|
||||||
|
|
||||||
class AgedBrie(Item):
|
class AgedBrie(Item):
|
||||||
|
def __init__(self, name, sell_in, quality):
|
||||||
|
self.name = name
|
||||||
|
self.sell_in = sell_in
|
||||||
|
self.quality = quality
|
||||||
|
|
||||||
def update_quality(self):
|
def update_quality(self):
|
||||||
self.quality = increase_quality(quality=self.quality)
|
self.quality = increase_quality(quality=self.quality)
|
||||||
@ -52,6 +67,10 @@ class AgedBrie(Item):
|
|||||||
|
|
||||||
|
|
||||||
class Conjured(Item):
|
class Conjured(Item):
|
||||||
|
def __init__(self, name, sell_in, quality):
|
||||||
|
self.name = name
|
||||||
|
self.sell_in = sell_in
|
||||||
|
self.quality = quality
|
||||||
|
|
||||||
def update_quality(self):
|
def update_quality(self):
|
||||||
self.quality = decrease_quality(quality=self.quality, sell_in=self.sell_in, decrease_quality_by=2)
|
self.quality = decrease_quality(quality=self.quality, sell_in=self.sell_in, decrease_quality_by=2)
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user