fix readme checkboxes

This commit is contained in:
Sallah Kokaina 2019-11-01 19:58:31 +01:00
parent c02dc07db1
commit aedfbf90f1

View File

@ -9,35 +9,35 @@
- At the end of each day our system lowers both values for every item
# unit tests
-[x] At the end of each day our system lowers both values for every item
-[x] Once the sell by date has passed, Quality degrades twice as fast
-[x] The Quality of an item is never negative
-[x] "Aged Brie" actually increases in Quality the older it gets
-[x] The Quality of an item is never more than 50
-[x] "Sulfuras", being a legendary item, never has to be sold or decreases in Quality
-[x] "Backstage passes", like aged brie, increases in Quality as its SellIn value approaches;
-[x] Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but
-[x] Quality drops to 0 after the concert
-[x] an item can never have its Quality increase above 50
-[x] however "Sulfuras" is a legendary item and as such its Quality is 80 and it never alters.
- [x] At the end of each day our system lowers both values for every item
- [x] Once the sell by date has passed, Quality degrades twice as fast
- [x] The Quality of an item is never negative
- [x] "Aged Brie" actually increases in Quality the older it gets
- [x] The Quality of an item is never more than 50
- [x] "Sulfuras", being a legendary item, never has to be sold or decreases in Quality
- [x] "Backstage passes", like aged brie, increases in Quality as its SellIn value approaches;
- [x] Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but
- [x] Quality drops to 0 after the concert
- [x] an item can never have its Quality increase above 50
- [x] however "Sulfuras" is a legendary item and as such its Quality is 80 and it never alters.
## Technical Issues, with a balanced priority
-[x] item names are hardcoded
-[x] items are identified by the name in a hardcoded way
-[x] nested logic
-[x] long method
-[x] plain logic
-[x] complex operations
-[x] Item properties are public
-[x] multiple access by index
- [x] item names are hardcoded
- [x] items are identified by the name in a hardcoded way
- [x] nested logic
- [x] long method
- [x] plain logic
- [x] complex operations
- [x] Item properties are public
- [x] multiple access by index
## Refactoring actions
-[x] extract hardcoded variables
-[x] create polymorphism for items
-[x] move item names as item members
-[x] extract methods
-[x] extract boolean methods
-[x] encapsulate methods
-[x] isolate specific logics
-[x] move specific logic to backstage
-[x] move specific logic of sulfuras
- [x] extract hardcoded variables
- [x] create polymorphism for items
- [x] move item names as item members
- [x] extract methods
- [x] extract boolean methods
- [x] encapsulate methods
- [x] isolate specific logics
- [x] move specific logic to backstage
- [x] move specific logic of sulfuras