OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Cleanup

Browse Source
This commit is contained in:
tbuckinx 2023-11-23 22:42:46 +01:00
parent d4ccdfe0e9
commit afc32f86f7
7 changed files with 16 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -3,7 +3,6 @@ package com.gildedrose;
import com.gildedrose.domain.*;
import com.gildedrose.domain.InventoryItem;
import static java.util.stream.IntStream.range;
import static java.util.stream.Stream.of;
class GildedRose {
@ -26,17 +25,11 @@ class GildedRose {
// reduce sellIn
item.sellIn = inventoryItem.reduceSellIn();
// increase quality when quality decrease is inverted
if (inventoryItem.qualityDecreaseInverted()) {
item.quality = inventoryItem.increaseQualityBelowMaximum();
}
// decrease quality based on their decrease amount
else {
range(0, inventoryItem.qualityDecreaseAmount()).forEach(i -> item.quality = inventoryItem.decreaseQualityAboveZero());
}
// increase or decrease quality based on the items
item.quality = inventoryItem.handleQuality();
if (item.sellIn < 0) {
// increase or decrease quality more after sell in
item.quality = inventoryItem.handleQualityAfterSellIn();
}
});

5
Java/src/main/java/com/gildedrose/domain/AgedBrie.java
View File

@ -11,8 +11,9 @@ public class AgedBrie extends InventoryItem {
}
@Override
public boolean qualityDecreaseInverted() {
return true;
public int handleQuality() {
quality = increaseQualityBelowMaximum();
return quality;
}
@Override

5
Java/src/main/java/com/gildedrose/domain/BackstagePass.java
View File

@ -11,8 +11,9 @@ public class BackstagePass extends InventoryItem {
}
@Override
public boolean qualityDecreaseInverted() {
return true;
public int handleQuality() {
quality = increaseQualityBelowMaximum();
return quality;
}
@Override

5
Java/src/main/java/com/gildedrose/domain/ConjuredItem.java
View File

@ -10,11 +10,6 @@ public class ConjuredItem extends InventoryItem {
setQuality(item.quality);
}
@Override
public boolean qualityDecreaseInverted() {
return false;
}
@Override
public int qualityDecreaseAmount() {
return 2;

5
Java/src/main/java/com/gildedrose/domain/DefaultItem.java
View File

@ -10,11 +10,6 @@ public class DefaultItem extends InventoryItem {
setQuality(item.quality);
}
@Override
public boolean qualityDecreaseInverted() {
return false;
}
@Override
public int qualityDecreaseAmount() {
return 1;

9
Java/src/main/java/com/gildedrose/domain/InventoryItem.java
View File

@ -3,6 +3,8 @@ package com.gildedrose.domain;
import lombok.NoArgsConstructor;
import lombok.Setter;
import static java.util.stream.IntStream.range;
@NoArgsConstructor
@Setter
public abstract class InventoryItem {
@ -12,8 +14,6 @@ public abstract class InventoryItem {
public int quality;
public int sellIn;
public abstract boolean qualityDecreaseInverted();
public abstract int qualityDecreaseAmount();
public abstract int handleQualityAfterSellIn();
@ -34,4 +34,9 @@ public abstract class InventoryItem {
sellIn--;
return sellIn;
}
public int handleQuality() {
range(0, qualityDecreaseAmount()).forEach(i -> quality = decreaseQualityAboveZero());
return quality;
}
}

5
Java/src/main/java/com/gildedrose/domain/Legendary.java
View File

@ -11,11 +11,6 @@ public class Legendary extends InventoryItem {
setQuality(item.quality);
}
@Override
public boolean qualityDecreaseInverted() {
return false;
}
@Override
public int qualityDecreaseAmount() {
return 0;